JBoss 3.2.0 says must override equals()

[gsinohio]

I'm deploying a BMP EJB to JBoss 3.2.0 and it says I must overried equals() and hashcode(). But take a look at the code, I am...


/**
* Returns true if both keys are equal.
*/
public boolean equals(java.lang.Object otherKey)
{
if (otherKey instanceof com.mtdproducts.crm.ejb.customer.customerEntity.CustomerEntityKey)
{
com.mtdproducts.crm.ejb.customer.customerEntity.CustomerEntityKey o = (com.mtdproducts.crm.ejb.customer.customerEntity.CustomerEntityKey)otherKey;
return (super.equals(otherKey));
}
return false;
}

/**
* Returns the hash code for the key.
*/
public int hashCode() {
return (super.hashCode());
}

Any ideas?

[gsinohio]

BTW, the code is out of the PrimaryKey class which is what JBoss3.2.0 is complaining about.

[adrian.brock]

super.equals(otherKey));
I assume is the implementation from
java.lang.Object

Your implementation is incorrect, you are
checking object reference equality not object
equality.
i.e. this == otherKey

new CustomerEntityKey() == new CustomerEntityKey()
is false

You should have something like:

public class PrimaryKey
{
public String myKey1;

public boolean equals(Object test)
{
if (test == this) return true;
if (test == null || !(test instanceof PrimaryKey)) return false;
PrimaryKey other = (PrimaryKey) test;
return this.myKey1.equals(other.myKey1);
}
public int hashCode()
{
return myKey1.hashCode();
}
}

Regards,
Adrian

[gsinohio]

That took care of it. Thanks!!!