JBMICROCONT-100, lifecycle dispatch thread context class loa

[starksm64]

For http://jira.jboss.com/jira/browse/JBMICROCONT-100, the thread context class loader needs to be set to the bean class loader. It looks like this should be done from the org.jboss.kernel.plugins.dependency.LifecycleAction.installAction/uninstallAction template methods.

[starksm64]

Adding the following code to the installAction does solve the problem.

 // Dispatch the joinpoint using the target class loader
 joinpoint.setTarget(target);
 ClassLoader tcl = Thread.currentThread().getContextClassLoader();
 try
 {
 if( cl != null )
 Thread.currentThread().setContextClassLoader(cl);
 dispatchJoinPoint(context, joinpoint);
 }
 finally
 {
 if( cl != null )
 Thread.currentThread().setContextClassLoader(tcl);
 }

I checked this in with similar additions to the uninstallAction. If this looks fine I'll close the issue tomorrow.

[adrian.brock]

This should really be done for all callouts to the bean.
i.e. it should be in
KernelControllerContextAction::dispatchJoinPoint()

[starksm64]

Then shouldn't that protected method have its signature changed to accept the target ClassLoader?

[adrian.brock]

Why? When you can do:

 BeanMetaData metaData = context.getBeanMetaData();
 ClassLoader cl = Configurator.getClassLoader(metaData);

[starksm64]

Because that is already done in LifecycleAction, and 50% of the current callers. In the ConfigureAction.setAttributes we are looping over the same context/target so why have to do this lookup repeatedly?