FileHandler.getChildren IOException for non-dirs

[starksm64]

I'm seeing a failure due to the behavior of the FileHandler.getChildren method when called for a non-dir file. I don't know why we want to do this as it makes it difficult to handle files consistently. It would seem better to return an empty list.

18:01:42,239 WARN [DeployersImpl] DeploymentContext has no DeploymentControllerContext during undeploy request, ignoring: AbstractVFSDeploymentContext@1587954306{vfsfile:/home/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.Beta3/server/profileservice/deploy/testAddDataSource-dsf.xml}
18:01:42,258 ERROR [EJBRegistrationDeployer] Error during deploy: vfsfile:/home/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.Beta3/server/profileservice/deploy/testAddDataSource-dsf.xml
org.jboss.deployers.spi.DeploymentException: java.lang.RuntimeException: java.io.IOException: Error listing files: /home/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.Beta3/server/profileservice/deploy/testAddDataSource-dsf.xml
 at org.jboss.ejb3.deployers.EJBRegistrationDeployer.deploy(EJBRegistrationDeployer.java:172)
 at org.jboss.deployers.vfs.spi.deployer.AbstractVFSRealDeployer.deploy(AbstractVFSRealDeployer.java:45)
...
Caused by: java.io.IOException: Error listing files: /home/svn/JBossHead/jboss-head/build/output/jboss-5.0.0.Beta3/server/profileservice/deploy/testAddDataSource-dsf.xml
 at org.jboss.virtual.plugins.context.file.FileHandler.getChildren(FileHandler.java:146)
 at org.jboss.virtual.plugins.context.AbstractVFSContext.getChildren(AbstractVFSContext.java:109)
 at org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:165)
 at org.jboss.virtual.plugins.context.AbstractVFSContext.visit(AbstractVFSContext.java:134)
 at org.jboss.virtual.VFS.visit(VFS.java:313)
 at org.jboss.virtual.VirtualFile.visit(VirtualFile.java:363)
 at org.jboss.ejb3.deployers.JBoss5DeploymentUnit.getResources(JBoss5DeploymentUnit.java:186)
 ... 30 more

[adrian.brock]

It's missing an isLeaf() check before trying to visit the file.
But I agree, there's no point invoking isLeaf() twice (once by the caller
and once by the backed) when it could just return an empty list.

[starksm64]

For now I have added the isLeaf check as making the change would break some of the unit tests in the vfs project and wanted to be sure this is a behavior change we want to make. I have created a jira issue to change this behavior.
http://jira.jboss.com/jira/browse/JBMICROCONT-195