10 Replies Latest reply on Jul 28, 2008 12:49 PM by maxandersen

    Problems with the Visual Page Editor with Tools 2.1.0 GA

    jimball

      Apologies if there is a fix for this already.

      I had a way older version of JBoss tools and decided it was time to upgrade.

      I have:-

      Windows XP SP2
      Eclipse 3.2.2 M20080221-1800, so the one off the eclipse site
      JBoss Tools 2.1.0 GA

      I also followed the blog in terms of updating to 2.0.2 of the WTP.

      When opening a JSP which with older versions of the tools, displayed fine in the VPE in terms of both the the code and the preview panels, I am encountering a problem.

      The new VPE holds an either/or for Visual/Source or Preview, and with the new version the Visual panel, and the Preview displays are empty.

      Checking the Eclipse logs, I'm seeing the following bug:

      java.lang.IllegalArgumentException: URLDecoder: Illegal hex characters in escape (%) pattern - For input string: "= "
      at java.net.URLDecoder.decode(Unknown Source)
      at org.jboss.tools.vpe.editor.template.expression.VpeFunctionSrc.exec(VpeFunctionSrc.java:58)
      at org.jboss.tools.vpe.editor.template.VpeAttributeCreator.create(VpeAttributeCreator.java:55)
      at org.jboss.tools.vpe.editor.template.VpeCopyCreator.create(VpeCopyCreator.java:98)
      at org.jboss.tools.vpe.editor.template.VpeHtmlTemplate.createVisualElement(VpeHtmlTemplate.java:193)
      at org.jboss.tools.vpe.editor.template.VpeHtmlTemplate.create(VpeHtmlTemplate.java:149)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:462)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.createNode(VpeVisualDomBuilder.java:525)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addNode(VpeVisualDomBuilder.java:307)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.addChildren(VpeVisualDomBuilder.java:610)
      at org.jboss.tools.vpe.editor.VpeVisualDomBuilder.buildDom(VpeVisualDomBuilder.java:228)
      at org.jboss.tools.vpe.editor.VpeController.init(VpeController.java:249)
      at org.jboss.tools.vpe.editor.VpeEditorPart$16.load(VpeEditorPart.java:747)
      at org.jboss.tools.vpe.editor.mozilla.MozillaEditor.onLoadWindow(MozillaEditor.java:477)
      at org.jboss.tools.vpe.editor.mozilla.MozillaEditor.access$1(MozillaEditor.java:472)
      at org.jboss.tools.vpe.editor.mozilla.MozillaEditor$4.onLoadWindow(MozillaEditor.java:218)
      at org.jboss.tools.vpe.xulrunner.browser.XulRunnerBrowser.onStateChange(XulRunnerBrowser.java:403)
      at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
      at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2265)
      at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3291)
      at org.jboss.tools.vpe.editor.mozilla.MozillaEditor.createPartControl(MozillaEditor.java:255)
      at org.jboss.tools.vpe.editor.VpeEditorPart.createVisualEditor(VpeEditorPart.java:753)
      at org.jboss.tools.jst.jsp.jspeditor.JSPMultiPageEditor.pageChange(JSPMultiPageEditor.java:212)
      at org.jboss.tools.jst.jsp.jspeditor.JSPMultiPageEditor.createPages(JSPMultiPageEditor.java:411)
      at org.jboss.tools.jst.jsp.jspeditor.JSPMultiPageEditorPart.createPartControl(JSPMultiPageEditorPart.java:125)
      at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:661)
      at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:426)
      at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:592)
      at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:299)
      at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:179)
      at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:268)
      at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
      at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:400)
      at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1256)
      at org.eclipse.ui.internal.PartStack.setSelection(PartStack.java:1209)
      at org.eclipse.ui.internal.PartStack.showPart(PartStack.java:1604)
      at org.eclipse.ui.internal.PartStack.add(PartStack.java:499)
      at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:103)
      at org.eclipse.ui.internal.PartStack.add(PartStack.java:485)
      at org.eclipse.ui.internal.EditorStack.add(EditorStack.java:112)
      at org.eclipse.ui.internal.EditorSashContainer.addEditor(EditorSashContainer.java:63)
      at org.eclipse.ui.internal.EditorAreaHelper.addToLayout(EditorAreaHelper.java:217)
      at org.eclipse.ui.internal.EditorAreaHelper.addEditor(EditorAreaHelper.java:207)
      at org.eclipse.ui.internal.EditorManager.createEditorTab(EditorManager.java:774)
      at org.eclipse.ui.internal.EditorManager.openEditorFromDescriptor(EditorManager.java:673)
      at org.eclipse.ui.internal.EditorManager.openEditor(EditorManager.java:634)
      at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditorBatched(WorkbenchPage.java:2737)
      at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:2651)
      at org.eclipse.ui.internal.WorkbenchPage.access$13(WorkbenchPage.java:2643)
      at org.eclipse.ui.internal.WorkbenchPage$10.run(WorkbenchPage.java:2595)
      at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:67)
      at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2590)
      at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2574)
      at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2565)
      at org.eclipse.ui.ide.IDE.openEditor(IDE.java:644)
      at org.eclipse.ui.ide.IDE.openEditor(IDE.java:603)
      at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:286)
      at org.eclipse.jdt.internal.ui.javaeditor.EditorUtility.openInEditor(EditorUtility.java:139)
      at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:194)
      at org.eclipse.jdt.ui.actions.OpenAction.run(OpenAction.java:175)
      at org.eclipse.jdt.ui.actions.SelectionDispatchAction.dispatchRun(SelectionDispatchAction.java:268)
      at org.eclipse.jdt.ui.actions.SelectionDispatchAction.run(SelectionDispatchAction.java:244)
      at org.eclipse.jdt.internal.ui.packageview.PackageExplorerActionGroup.handleOpen(PackageExplorerActionGroup.java:316)
      at org.eclipse.jdt.internal.ui.packageview.PackageExplorerPart$5.open(PackageExplorerPart.java:613)
      at org.eclipse.jface.viewers.StructuredViewer$2.run(StructuredViewer.java:820)
      at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:37)
      at org.eclipse.core.runtime.Platform.run(Platform.java:857)
      at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:46)
      at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:199)
      at org.eclipse.jface.viewers.StructuredViewer.fireOpen(StructuredViewer.java:818)
      at org.eclipse.jface.viewers.StructuredViewer.handleOpen(StructuredViewer.java:1079)
      at org.eclipse.jface.viewers.StructuredViewer$6.handleOpen(StructuredViewer.java:1183)
      at org.eclipse.jface.util.OpenStrategy.fireOpenEvent(OpenStrategy.java:263)
      at org.eclipse.jface.util.OpenStrategy.access$2(OpenStrategy.java:257)
      at org.eclipse.jface.util.OpenStrategy$1.handleEvent(OpenStrategy.java:297)
      at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
      at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:938)
      at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3682)
      at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3293)
      at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2389)
      at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2353)
      at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2219)
      at org.eclipse.ui.internal.Workbench$4.run(Workbench.java:466)
      at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:289)
      at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:461)
      at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
      at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:106)
      at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:169)
      at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:106)
      at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:76)
      at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:363)
      at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:176)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
      at java.lang.reflect.Method.invoke(Unknown Source)
      at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:508)
      at org.eclipse.equinox.launcher.Main.basicRun(Main.java:447)
      at org.eclipse.equinox.launcher.Main.run(Main.java:1173)
      


      Honest, there ain't anything up with the code, it displays okay in the Eclipse built in "Web Page Editor" and worked fine in previous builds.

      Any help would be greatly appreciated, as I started with a vanilla install of Eclipse, and JBoss Tools here, and cannot get the VPE to work. I'd much rather use it than the built in "Web Page Editor", its way cooler.

        • 1. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
          jimball

          This problem did not occur with 2.0.0.Beta3 of the tools.

          • 2. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
            maxandersen

            please report this in jira and possibly with an attachment of the page causing the problem.

            Thanks

            • 3. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
              jimball

              Okay, I've opened a bug in JIRA at

              http://jira.jboss.org/jira/browse/JBIDE-2297

              I've also attached the JSP, although the problem occurs for all the JSP in the project, not just this one, hence me raising the bug on the VPE.

              I've also added a full listing of the plugins and features I have installed within Eclipse, as this could well be a cause, and a way of duplicating the problem.

              Note, all plugins and features were added using the find and install mechanism within Eclipse apart from the Jboss Tools themselves, which were a last thing of all, written over the top of the updated plugins and features from the ZIP.

              Also, I've start eclipse with the -clean option without result. I also tried it with -debug, but perhaps got nothing meaningful in relation to the bug (three lines with the output of "aaa" tacked onto the end of the console output) which was odd.

              • 4. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                jimball

                Note, all the attachments and details are on the JIRA case. I could duplicate them here, but I don't want to nark you off.

                • 5. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                  jimball

                  Note:-

                  he same problem occurs in the commerical release of Red Hat Developer Studio.

                  So in jbdevstudio-win32-1.1.0.CR1.jar, the VPE has problems displaying JSP pages.

                  • 6. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                    dgolovin
                    • 7. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                      jimball

                      I'm going to guess its not too hard to do, but I'd like to patch the JBoss Developer Studio version I bought for $99 with the latest JBoss Tools.

                      Are there any gotcha's as I've not seen ANY guidlines for patching your local developer studio with an updated JBoss Tools.

                      I really don't want to have to setup a completely new development environment to validate this bug.

                      Please confirm the basic steps to patch upgrade Developer Studio with the release of JBoss Tools 2.1.2 GA.

                      Once done, I'll confirm the fix no problem in my patched dev studio. Much obliged.

                      • 8. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                        jimball

                        Right, I couldn't find what I needed in terms of RHDS or JBDS update instructions to go up to 2.1.2 GA of the JBoss Tools. Probably because RedHat have a different test release cycle, and who is responsible for getting the tools into RHDS is in a different part of the organisation, and its not ready yet.

                        No worries, I understand this, and at some point RHDS or JBDS will be updated. I'll just avoid using it till I do know the upgrade path.

                        Anyway, to confirm the fix for vanilla Europa: I used the winter release of Eclipse Europa as my start, added checkstyle, and then put the new 2.1.2 GA release of JBoss Tools.

                        On opening a standard JSP page now in the Visual Page Editor (VPE) the panel displays a JSP as they should be displayed (nice job by the way) bar one thing.

                        There is only one minor difference from previous versions, now the placeholders for iconography (images, whatever) that use an "img" tag are zero width on the preview panel, which is different from the original, and makes it difficult to visually review your page or page fragment of its full content and layout.

                        Whatever, its not a major bug. But if you want to make the VPE properly user friendly, I'd use a notional width on the preview panel for iconography applying the "img" tag, so developers can see the notional "layout" including imagery both in the vertical and the horizontal.

                        Thanks to you all for fixing the JSP display problem, I'll live with the chocolate teapot JBDS (just not bother using it), and the zero width img placeholders, by cross-referencing with Firefox.

                        Most appreciated.

                        • 9. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                          maxandersen

                          did you try JBDS 1.1 ?

                          btw. would be great with screenshots in jira.

                          • 10. Re: Problems with the Visual Page Editor with Tools 2.1.0 GA
                            maxandersen

                            p.s. about updating JBDS with random version of jboss tools is doable in most cases by just putting in the plugins/features into the plugins/features directory but it is totally untested by us so I cannot gurantee it.