JBoss tools 3 daily Deployment failure due to spaces?

[bdlink]

Windows OS. Started with Eclipse 3.4.1 EE version, updated with BRIT and JBoss Tools update site enabled. Installed latest daily, N200812080252. Added JBoss AS 4.2.3.GA as "JBoss, a division of Red Hat JBoss 4.2 Runtime" and created a new local server by checking checkbox in New Server Runtime Environment wizard.

Created new Seam project, testseam, and added Jboss-seam-2.0.2.SP1 as Seam Runtime version 2.0 (remark - it would not allow adding a version 2.1 here, but does allow it via preferences window) (remark - when opening seam runtime in preferences window and selecting edit, it sets version to 1.2 instead of picking up current version setting). Connector was MYSQL (innodb) to exisiting database I use for testing (this process has worked in the past, and works on JBDS 2 beta - using stock server and seam).

Try to run on server, get exception (traceback edited down):

12:49:25,218 ERROR [[/testseam]] Exception sending context initialized event to listener instance of class org.jboss.seam.servlet.SeamListener
org.jboss.seam.InstantiationException: Could not instantiate Seam component: testseamEntityManagerFactory
...
Caused by: javax.persistence.PersistenceException: java.lang.IllegalArgumentException: Unable to visit JAR file:/C:/apps/workspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/WEB-INF/classes. Cause: Illegal character in path at index 83: file:/C:/apps/workspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/WEB-INF/classes
...
Caused by: java.lang.IllegalArgumentException: Unable to visit JAR file:/C:/apps/workspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/WEB-INF/classes. Cause: Illegal character in path at index 83: file:/C:/apps/workspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/WEB-INF/classes
 at org.hibernate.ejb.packaging.JarVisitor.getVisitor(JarVisitor.java:100)
 at org.hibernate.ejb.Ejb3Configuration.configure(Ejb3Configuration.java:226)
 ... 175 more
12:49:25,234 ERROR [StandardContext] Error listenerStart
12:49:25,234 ERROR [StandardContext] Context [/testseam] startup failed due to previous errors
12:49:25,234 WARN [ServiceController] Problem starting service jboss.web.deployment:war=testseam.war,id=-1001488612
org.jboss.deployment.DeploymentException: URL file:/C:/apps/workspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/ deployment failed

Problem seems to be spaces in path (char at index 83 mentioned in error is a space). I used default names for server given by add runtime wizard.

[rob.stryker]

Already fixed ;) I think.

[JBoss JIRA] Commented: (JBIDE-3368) In WINDOWS default metadata location CONTAINS SPACES, no good

Committed a fix earlier today.

[maxandersen]

This has nothing to do with JBoss Tools afaik.

This is caused by a bug in hibernate entity manager which is fixed by using a more recent version.

Rob - what fix did you commit earlier that should relate to this ?

[maxandersen]

Ah found it - ok, that commit for JBIDE-3368 is also related to spaces but should not cause the exception bdlink is seeing here afaik.

[rob.stryker]

Cause: Illegal character in path at index 83: file:/C:/apps/w
orkspace3.4.1/.metadata/.plugins/org.jboss.ide.eclipse.as.core/JBoss 4.2 Server/deploy/testseam.war/
WEB-INF/classes
...


Yes it should.

[rob.stryker]

This should have been fixed by JBIDE-3368 for the record.

[maxandersen]

Well, lets be clear here ;)

Having spaces in deployment is completely ok, but Hibernate JPA in older versions of AS would fail with this PersistenceException. This issue was fixed in later AS's and if you use that you will also not see this issue.

I assume JBIDE-3368 works around this by adding _ instead of spaces in the server name, but that does not remove the underlying bug - it just workaround it.