3 Replies Latest reply on May 27, 2008 4:52 AM by alrubinger

    Persistence metadata change

    alesj
    alesj May 27, 2008 4:20 AM

      I've changed the usage of PersistenceMetaData in Ejb3/core.
      It now uses classes from our metadata project - instead of some wrapper hack with hibernate.

      Chatting with Carlo, we didn't seem to find any relevant tests that would verify this change.

      I also made changes to AS5_trunk, to use this, but I haven't commited yet - waiting for new ejb3 release that will include this latest changes.
      This will break AS5_trunk for a while, so let me know when you plan to do the update/switch, and I'll commit my changes immediately after that - or even better, I'll do the ejb3 switch in component-matrix.

      For a simple test, to see if things at least work, I ran ALR's service-test.jar.
      Things were picked up, parsed, deployed as expected (OK, there was some HEM problems with VFS, but not relevant to this change).

      • 6035 Views
      • Tags:
        • 1. Re: Persistence metadata change
          alrubinger
          alrubinger May 27, 2008 4:30 AM (in response to alesj)

           

          "alesj" wrote:
          For a simple test, to see if things at least work, I ran ALR's service-test.jar.


          Let's try running with one of the JPA tests, anything from the EJB3 Core TestSuite under the "entity" heading should do.

          S,
          ALR

            • Actions
          • 2. Re: Persistence metadata change
            alesj
            alesj May 27, 2008 4:47 AM (in response to alesj)

             

            "ALRubinger" wrote:

            Let's try running with one of the JPA tests, anything from the EJB3 Core TestSuite under the "entity" heading should do.

            In AS5 testsuite?
            Or EJB3 project testsuite?

            If 2nd, shouldn't this be part of 'mvn install'?
            I ran that, catching any FAILURE text, ... nothing there.

            It's not really a business logic change/update.
            The relevant tests for this are probably the one's in metadata, which test if PMD is capable of mapping to the actual persistence.xml file.

              • Actions
            • 3. Re: Persistence metadata change
              alrubinger
              alrubinger May 27, 2008 4:52 AM (in response to alesj)

              EJB3 Project TestSuite.

              "mvn install" should execute quickly, and we're using it for all of our Unit Tests. The TestSuite I mention is more of an integration suite, and takes about 90 minutes to run fully. So you see why we exclude it by default. :)

              If the metadata tests cover the change, that's good enough for me. Carlo will have different opinions as he'd like to verify jboss-metadata results in EJB3 (to ensure that we're consuming a valid component).

              S,
              ALR

                • Actions