Deploying Apache DayTrader on AS 5.1

[andy.miller]

I'm trying to build the Apache Day Trader application using the jboss5 instructions they give, and I have an ear, but when I deploy it I get the following deployment exception (NullPointerException):

19:36:07,745 INFO [JBossASKernel] installing bean: jboss.j2ee:ear=daytrader-ear-2.1.3.ear,jar=wsappclient.jar,name=wsappclient,service=EJB3
19:36:07,746 INFO [JBossASKernel] with dependencies:
19:36:07,746 INFO [JBossASKernel] and demands:
19:36:07,746 INFO [JBossASKernel] and supplies:
19:36:07,746 INFO [JBossASKernel] Added bean(jboss.j2ee:ear=daytrader-ear-2.1.3.ear,jar=wsappclient.jar,name=wsappclient,service=EJB3) to KernelDeployment of: wsappclient.jar
19:36:09,575 ERROR [AbstractKernelController] Error installing to Real: name=vfszip:/home/andrig/jboss-eap-5.0/jboss-as/server/daytrader/deploy/daytrader-ear-2.1.3.ear/ state=PreReal mode=Manual requiredState=Real
org.jboss.deployers.spi.DeploymentException: Error deploying dt-ejb.jar: null
at org.jboss.ejb3.deployers.Ejb3Deployer.deploy(Ejb3Deployer.java:196)
at org.jboss.ejb3.deployers.Ejb3Deployer.deploy(Ejb3Deployer.java:99)
at org.jboss.deployers.vfs.spi.deployer.AbstractVFSRealDeployer.internalDeploy(AbstractVFSRealDeployer.java:45)
at org.jboss.deployers.spi.deployer.helpers.AbstractRealDeployer.deploy(AbstractRealDeployer.java:50)
at org.jboss.deployers.plugins.deployers.DeployerWrapper.deploy(DeployerWrapper.java:171)
at org.jboss.deployers.plugins.deployers.DeployersImpl.doDeploy(DeployersImpl.java:1439)
at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1157)
at org.jboss.deployers.plugins.deployers.DeployersImpl.doInstallParentFirst(DeployersImpl.java:1210)
at org.jboss.deployers.plugins.deployers.DeployersImpl.install(DeployersImpl.java:1098)
at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)
at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1598)
at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:934)
at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1062)
at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:984)
at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:822)
at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:553)
at org.jboss.deployers.plugins.deployers.DeployersImpl.process(DeployersImpl.java:781)
at org.jboss.deployers.plugins.main.MainDeployerImpl.process(MainDeployerImpl.java:698)
at org.jboss.system.server.profileservice.repository.MainDeployerAdapter.process(MainDeployerAdapter.java:117)
at org.jboss.system.server.profileservice.repository.ProfileDeployAction.install(ProfileDeployAction.java:59)
at org.jboss.system.server.profileservice.repository.AbstractProfileAction.install(AbstractProfileAction.java:53)
at org.jboss.system.server.profileservice.repository.AbstractProfileService.install(AbstractProfileService.java:355)
at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)
at org.jboss.dependency.plugins.AbstractController.install(AbstractController.java:1598)
at org.jboss.dependency.plugins.AbstractController.incrementState(AbstractController.java:934)
at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:1062)
at org.jboss.dependency.plugins.AbstractController.resolveContexts(AbstractController.java:984)
at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:822)
at org.jboss.dependency.plugins.AbstractController.change(AbstractController.java:553)
at org.jboss.system.server.profileservice.repository.AbstractProfileService.activateProfile(AbstractProfileService.java:310)
at org.jboss.system.server.profileservice.ProfileServiceBootstrap.start(ProfileServiceBootstrap.java:241)
at org.jboss.bootstrap.AbstractServerImpl.start(AbstractServerImpl.java:461)
at org.jboss.Main.boot(Main.java:216)
at org.jboss.Main$1.run(Main.java:546)
at java.lang.Thread.run(Thread.java:636)
Caused by: java.lang.NullPointerException
at org.jboss.injection.ResourceHandler.loadXmlResourceRefs(ResourceHandler.java:185)
at org.jboss.injection.ResourceHandler.loadXml(ResourceHandler.java:335)
at org.jboss.ejb3.EJBContainer.processMetadata(EJBContainer.java:588)
at org.jboss.ejb3.Ejb3Deployment.processEJBContainerMetadata(Ejb3Deployment.java:418)
at org.jboss.ejb3.Ejb3Deployment.start(Ejb3Deployment.java:526)
at org.jboss.ejb3.deployers.Ejb3Deployer.deploy(Ejb3Deployer.java:189)
... 34 more

[alrubinger]

What's up with the deployment ie. ejb-jar.xml or @Resource annotations? If we can get a failing case we should either:

1) Throw descriptive deployment exception if caused by invalid metadata
2) Fix this NPE

...but either way the error as-is offers no feedback and should be chased down/fixed.

S,
ALR

[alrubinger]

BTW the line in question is:

if(envRef.getType().equals(URL.class.getName()))

...so a blind guess is that type is null, and we could check for

final String type = envRef.getType();
if(type!=null&&type.equals(URL.class.getName()))

...but hey that's conjecture, let's see a failing case. :D

S,
ALR

[jaikiran]

Second time someone has reported this exact same error with this application http://www.jboss.org/index.html?module=bb&op=viewtopic&t=154334. Let me see what the application contains.

[andy.miller]

"ALRubinger" wrote:
What's up with the deployment ie. ejb-jar.xml or @Resource annotations? If we can get a failing case we should either:

1) Throw descriptive deployment exception if caused by invalid metadata
2) Fix this NPE

...but either way the error as-is offers no feedback and should be chased down/fixed.

S,
ALR

I'll send you the ear file. The ejb-jar.xml file is empty, but in the ear. I'll try to zip up the source files too.

[jaikiran]

There appears to be an misconfiguration in that application. Specifically, there's an resource-ref entry in jboss.xml for the datasource:

<resource-ref>
 <res-ref-name>jdbc/TradeDataSource</res-ref-name>
 <!-- If using DB2, comment out this line -->
 <jndi-name>jdbc/TradeDataSource</jndi-name>
 <!-- If using MySql or Oracle, use this line -->
 <!-- <jndi-name>java:jdbc/TradeDataSource</jndi-name> -->
 </resource-ref>

But there is no corresponding entry for this resource-ref, neither in ejb-jar.xml nor as a @Resource in the TradeSLSBBean. This leads to the NPE. Removing the resource-ref from the jboss.xml (or providing the corresponding entry in ejb-jar.xml or as a @Resource in the bean) should fix this problem.
I'll file a EJB3 JIRA to provide better handling/message for this case.

[wolfc]

By spec res-type is mandatory if no injection target is given. In practice we can continue without, because it's just a LinkRef to the jndi-name.
Issue a warning, but allow the construct. Create a test case accordingly.

The bug was introduced with: https://jira.jboss.org/jira/browse/EJBTHREE-1635

[jaikiran]

"jaikiran" wrote:

I'll file a EJB3 JIRA to provide better handling/message for this case.

https://jira.jboss.org/jira/browse/EJBTHREE-1823