JBPORTAL-1978 : scriptaculous & prototype js

[chuaky]

hi,

Please refer to JBPORTAL-1978, i think Portal 2.6.5SP1 was upgraded to scriptalculous.js 1.8 version that can work with richfaces 3.2.1 datascroller.

But now, Portal 2.6.6 use back older scriptalculous.js 1.7, and cannot work with richfaces 3.2.1 datascroller.

How to work around this so that i can use Portal 2.6.6 and richfaces 3.2.1 ?
Thanks.

[theute]

Scriptaculous had to be rolledback because the upgrade broke the Drag And Drop feature of the dashboard.

Wesley didn't find the time yet to find what changed that broke the DnD so for now there is no solution.

If you are willing to look at the issues, i would be very glad :)

[chuaky]

oic, i try to see if by loading the new scriptaculous and prototype js from portal headers can be a workaround.

If i can find wat cause the problem, i would post it :)

Thanks Thomas.

[chuaky]

hi,

I try to manually add the scriptaculous.js into the header-content of the jboss-portlet.xml but got "resource not register" error. Guess, i would fall back to 2.6.5.SP1 :(

Thanks.

[wesleyhales]

Please refer to https://jira.jboss.org/jira/browse/JBPORTAL-2047

I started to track the problem but was not able to finish. Like Thomas said, if you want to further investigate until our time frees up, it would be much appreciated.

[cpage]

I use prototype 1.6.0.2 and scriptaculous 1.8.1 with Portal 2.6.6 and DnD is ok for me in IE7, FF2 and FF3. I have made changes only in dyna.js.

I have changed lot of things in Portal java code so i don't know if these changes in js will be ok for everyone.

The 5 lines in dyna.js :

replace line 27 :
var regions_on_page = document.getElementsByClassName("dnd-region");
by :
var regions_on_page = $$(".dnd-region");

replace line 221 :
var srcs = Element.getElementsByClassName(srcContainer, className);
by :
var srcs = srcContainer.select("." + className);

replace line 227 :
var dsts = Element.getElementsByClassName(dstContainer, className)
by :
var dsts = dstContainer.select("." + className);

replace line 306 :
var regions_on_page = document.getElementsByClassName("dnd-region");
by :
var regions_on_page = $$(".dnd-region");

replace line 321 :
var portlets_on_page = document.getElementsByClassName("partial-refresh-window");
by :
var portlets_on_page = $$(".partial-refresh-window");

[theute]

Sounds great ! Thanks a bunch !
Adding this to the Jira in your name

[wesleyhales]

This is in 2.7 trunk. Thanks!

[wesleyhales]

btw, I checked the code to see where drag and drop was failing and the only relevant change is the one at line 306 :
var regions_on_page = $$(".dnd-region");

Prototype uses the double dollar sign to getElementByClassNames but when you do this manually using the document.getElementByClassNames() js function the "drop" in drag and drop stops working.
It even returns the proper elements but for some reason the followinf for loop using Sortable.create does not handle the element... weird.

[cpage]

Indeed, FF3 implements the new function getElementsByClassName but return NodeList instead of Array.

I replaced also "Element.getElementsByClassName" because i had pb with the changes between view and edit modes (there was no refresh of the portlet content).

[dkrieger]

Its a little disheartening to hear that when I reported this way back in June it went completely ignored:

https://jira.jboss.org/jira/browse/JBPORTAL-2035

But i'm glad at least now I don't have to worry about manually updating dyna.js with each release...

[theute]

Sorry about that Dan :(

Not trying to justify but for some reason it got assigned to the wrong component CMS, so to the wrong person and also classified as "optional".

Hopefully this won't happen again and we won't loose any contribution anymore.

Thanks