Examples: Code Police ;-)

[stephen.friedrich]

A few validation errors where a fix would make my Idea projects a little bit greener.

f:subview without required id attribute
=======================================

dvdstore:
browse.xhtml, checkout.xhtml, complete.xhtml, confirm.xhtml, dvd.xhtml, showorders.xhtml, admin.xhtml, process.xhtml, complete.xhtml, cart.xhtml, processmenu.xhtml, stats.xhtml, store_nav.xhtml'

quartz:
search.xhtml

seampay:
search.xhtml


"class" attribute should be "styleClass"
========================================
contactlist:
search.xhtml (71)

quartz:
search.xhtml (49)

remoting:
progressbar.xhtml (73)

seampay:
search.xhtml (49)

[shane.bryzak]

Thanks, I've fixed these in CVS.

[stephen.friedrich]

Thanks for the quick fix.
If I may push my luck: There are a bunch of xhtml files which use a different root element than declared in the doctype:

booking:
conversations.xhtml

seampay:
search.xhtml

contactlist:
editContact.xhtml, viewContact.xhtml, search.xhtml

itext:
test.xhtml, y.xhtml, chartimage.xhtml, index.xhtml, pdfMissing.xhtml

jee5:
conversations.xhtml

mail:
index.xhtml

quartz:
search.xhtml

spring:
conversations.xhtml

ui:
cache.xhtml, fileUpload.xhtml, formattedText.xhtml, fragment.xhtml, graphicImage.xhtml, index.xhtml, linkAndButton.xhtml

[stephen.friedrich]

And finally (at least I hope so):

These component.xml files are missing declarations for the schema locations:

examples\quartz\resources\WEB-INF\components.xml
examples\seampay\resources\WEB-INF\components.xml

These are missing only declarations for persistence and transaction schemas:

examples\hibernate2\resources\components.xml
examples\hibernate2\resources-jboss\WEB-INF\components.xml
examples\hibernate2\resources\tomcat\components.xml
examples\hibernate2\resources-tomcat\WEB-INF\components.xml

And these are missing only transaction

examples\jpa\resources-glassfish\WEB-INF\components.xml
examples\jpa\resources-jboss\WEB-INF\components.xml
examples\jpa\resources-weblogic92\WEB-INF\components.xml
examples\jpa\resources-websphere61\WEB-INF\components.xml

[shane.bryzak]

Ugh, that's a lot of changes! Want to submit them as patches in JIRA? :)

[stephen.friedrich]

Sure, I can do that. Two separate issues/patches for missing schema locations and for incorrect doctype?

[shane.bryzak]

One single issue will be fine. You can assign to me if you like.

[stephen.friedrich]

Thanks, Shane, you were right those were lots of changes ;-)
I created JBSEAM-1742, but I can't assign the issue.

There are a couple of issues I noticed, but did not really have a clue what to do about. Maybe you can comment/act on these:

* mail, itext, takeaway:
- screen.css is referenced from xhtml files, but is missing.
I am not sure wether the reference is bogus, or wether the css file should indeed be there.

* seambay:
template.xhtml links non-existing style/date.css

* seamdiscs:
- messages_en.properties should be messages.properties?!
On my german locale I get lots of warning that messages_de can't be found. If I ain't mistaken if there's only a single "translation" it should be contained in the default properties file.
- All xyz.page.xml: rule definitions are invalid because they do not contain the required child element "raise-event"

* spring:
components.xml: These elements aren't defined in xsd:
<core:thread-pool-dispatcher>
<spring:spring-transaction>

* takeaway:
components.xml: <core:jbpm> is not defined in xsd