poor performance of getId() in Seam

[mgrouch]

getId method in Seam causes significant performance degradation.

Entity.forClass(bean.getClass()).getIdentifier(bean);

Has anyone noticed that too?
Thanks

[pmuir]

Have you noticed any particular use cases where this is bad? It gets used in a number of places. As we could try harder to cache the identifier in places where calls are heavy.

[mgrouch]

I can't point to particular place. One of the would be EntityConverter used
usually for dropdowns with s:selectItems. I'd say it should be optimized everywhere as depending on the application hotspots can vary.

It seems annotation reading using JDK API is expensive for performance.
I've found one library which claims to do it faster.

http://backport175.codehaus.org/

Might be that can help as well...

Thanks

[pmuir]

We are in general leery of using non-standard methods for doing this stuff so I would prefer to see if we can do some caching first.

So that this causes performance degradation is pure speculation?

[mgrouch]

These methods were amoungst several Seam methods in top of our profiler snapshot. It is not just speculation.

[pmuir]

Ok, I think we need to narrow down *where* these calls are coming from before we can work on performance improvements here.

Have you filed a jira issue for this one?

[mgrouch]

There is this one

http://jira.jboss.org/jira/browse/JBSEAM-2001

and another one (similar)

http://jira.jboss.org/jira/browse/JBSEAM-1966

[pmuir]

Neither of those deal with this issue. If you want us to look this issue please file a specific issue for it.

[mgrouch]

I've opened another one

http://jira.jboss.org/jira/browse/JBSEAM-2093