s:fileUpload using tempFile fails with an OutOfMemoryError

[pingus]

I've successfully configured the MultipartFilter in Seam 1.2.1.GA to use a temp file and to use a max. file size of 1GB (1073741824). The users will upload mid size videos.

When uploading a ~170MB file everything works, but uploading a ~550MB file raises an OutOfMemoryError.

2007-09-18 15:33:36,103 ERROR [org.jboss.seam.web.ExceptionFilter] uncaught exception
javax.servlet.ServletException: Java heap space
 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:152)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:79)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:63)
 at org.jboss.seam.debug.hot.HotDeployFilter.doFilter(HotDeployFilter.java:60)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:57)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:74)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.SeamFilter.doFilter(SeamFilter.java:84)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.ajax4jsf.framework.ajax.xmlfilter.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:127)
 at org.ajax4jsf.framework.ajax.xmlfilter.BaseFilter.doFilter(BaseFilter.java:277)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
 at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
 at org.jboss.web.tomcat.security.SecurityAssociationValve.invoke(SecurityAssociationValve.java:175)
 at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:432)
 at org.jboss.web.tomcat.security.JaccContextValve.invoke(JaccContextValve.java:74)
 at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
 at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
 at org.jboss.web.tomcat.tc5.jca.CachedConnectionValve.invoke(CachedConnectionValve.java:156)
 at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
 at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
 at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
 at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
 at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
 at org.apache.tomcat.util.net.MasterSlaveWorkerThread.run(MasterSlaveWorkerThread.java:112)
 at java.lang.Thread.run(Thread.java:595)
2007-09-18 15:33:36,105 ERROR [org.jboss.seam.web.ExceptionFilter] exception root cause
java.lang.OutOfMemoryError: Java heap space
 at java.io.ByteArrayOutputStream.write(ByteArrayOutputStream.java:95)
 at org.jboss.seam.web.MultipartRequest$FileParam.getData(MultipartRequest.java:217)
 at org.jboss.seam.web.MultipartRequest.getFileBytes(MultipartRequest.java:523)
 at org.jboss.seam.ui.UIFileUpload.decode(UIFileUpload.java:61)
 at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:606)
 at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:602)
 at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:602)
 at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:602)
 at javax.faces.component.UIForm.processDecodes(UIForm.java:53)
 at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:602)
 at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:135)
 at org.ajax4jsf.framework.ajax.AjaxViewRoot.access$001(AjaxViewRoot.java:53)
 at org.ajax4jsf.framework.ajax.AjaxViewRoot$1.invokeRoot(AjaxViewRoot.java:256)
 at org.ajax4jsf.framework.ajax.JsfOneOneInvoker.invokeOnRegionOrRoot(JsfOneOneInvoker.java:53)
 at org.ajax4jsf.framework.ajax.AjaxContext.invokeOnRegionOrRoot(AjaxContext.java:191)
 at org.ajax4jsf.framework.ajax.AjaxViewRoot.processDecodes(AjaxViewRoot.java:272)
 at org.apache.myfaces.lifecycle.LifecycleImpl.applyRequestValues(LifecycleImpl.java:219)
 at org.apache.myfaces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:71)
 at javax.faces.webapp.FacesServlet.service(FacesServlet.java:137)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:252)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:79)
 at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
 at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:63)
 at org.jboss.seam.debug.hot.HotDeployFilter.doFilter(HotDeployFilter.java:60)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:57)
 at org.jboss.seam.web.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:49)
 at org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:74)
2007-09-18 15:33:36,322 ERROR [org.jboss.seam.exceptions.DebugPageHandler] redirecting to debug page

The temporary file seems to be complete. Its size equals the original size.

Environment: JBoss 4.0.5, Seam 1.2.1.GA, Sun JDK 1.5.0_12 (64)

What do you think? Anyone else using such big file uploads?

Pingus

[tim_ph]

It uses ByteArrayOutputStream to hold data. The buffer grows as data adding to it. Look like you may have to increase the heap size -Xmx

[shane.bryzak]

If you're injecting the file data into your component as a byte[] then of course it needs to load the entire file into memory (which kind of defeats the purpose of using a temporary file). I recommend using an InputStream instead, then you can deal with the file data in smaller chunks.

[pingus]

OK, good to know (yes, it's a byte[]). Thanks for this info.