Error in documentation, or my understanding?

[matt.drees]

"Reference Documentation section 5.1.1.2" wrote:

But ending the conversation loses any state associated with the conversation, including the document we are currently interested in! One solution would be to use an immediate render instead of a redirect:

<page view-id="/editDocument.xhtml">

 <navigation from-action="#{documentEditor.update}">
 <rule if="#{documentEditor.errors.empty}">
 <end-conversation/>
 <render view-id="/viewDocument.xhtml"/>
 </rule>
 </navigation>

</page>

But the correct solution is to pass the document id as a request parameter:

<page view-id="/editDocument.xhtml">

 <navigation from-action="#{documentEditor.update}">
 <rule if="#{documentEditor.errors.empty}">
 <end-conversation/>
 <redirect view-id="/viewDocument.xhtml">
 <param name="documentId" value="#{documentEditor.documentId}"/>
 </redirect>
 </rule>
 </navigation>

</page>

I haven't tested this, but this strikes me as wrong. Conversations by default don't end until after a redirect, right? If beforeRedirect="true" was specified, then the param would be necessary. But as it is, it shouldn't be necessary. Please, correct me if I'm wrong.

[wschwendt]

"matt.drees" wrote:

I haven't tested this, but this strikes me as wrong. Conversations by default don't end until after a redirect, right?

you're right. I haven't tested this either, but I, too, would say this section in the Ref Docs is wrong.

I think that unless the beforeRedirect attribute of the "end-conversation" element is set to true, there's no need use the solution where the document id is explicitly passed as request parameter, no matter whether we navigate to "/viewDocument.xhtml" with a "redirect" or with a "render" element.


But the solution with the documentId request parameter can make sense if we want to avoid that view "/viewDocument.xhtml" can access any conversation-scoped context variables of the conversation we just ended after the update. But in order to do the latter we would in fact have to write "end-conversation" with redirect=true.

[wschwendt]

correction:

I think that unless the beforeRedirect attribute of the "end-conversation" element is set to true, there's no need _to_ use the solution where the document id is explicitly passed as request parameter, ...

[pmuir]

I think you are right Matt. Please open a JIRA issue.

[matt.drees]

Thanks Wolfgang and Pete.

http://jira.jboss.com/jira/browse/JBSEAM-1940