http session replication - javax.management.MalformedObjectNameException: Unterminated key property part(JBoss 5.1 GA)

[tfrastia]

Hi,

I have JBoss 5.1 GA (Liferay build) , when I added  <distributable/> tag to jbossServer/server/all/deploy/ROOT.war/WEB-INF/web.xml , show me this error:

ERROR [JBossCacheManager.] Could not register JBossCacheManager to MBeanServer
javax.management.MalformedObjectNameException: Unterminated key property part
        at javax.management.ObjectName.construct(ObjectName.java:465)
        at javax.management.ObjectName.<init>(ObjectName.java:1314)
        at org.jboss.web.tomcat.service.session.JBossManager.registerManagerMBean(JBossManager.java:1074)
        at org.jboss.web.tomcat.service.session.JBossManager.startManager(JBossManager.java:1152)
        at org.jboss.web.tomcat.service.session.JBossManager.start(JBossManager.java:608)
        at org.jboss.web.tomcat.service.session.JBossCacheManager.startEmbedded(JBossCacheManager.java:2307)
        at org.jboss.web.tomcat.service.session.JBossCacheManager.start(JBossCacheManager.java:657)
        at org.apache.catalina.core.ContainerBase.setManager(ContainerBase.java:447)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:592)
        at org.apache.tomcat.util.modeler.BaseModelMBean.setAttribute(BaseModelMBean.java:414)
        at org.jboss.mx.server.RawDynamicInvoker.setAttribute(RawDynamicInvoker.java:70)
        at org.jboss.mx.server.MBeanServerImpl.setAttribute(MBeanServerImpl.java:617)
        at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeployInternal(TomcatDeployment.java:348)
        at org.jboss.web.tomcat.service.deployers.TomcatDeployment.performDeploy(TomcatDeployment.java:142)
        at org.jboss.web.deployers.AbstractWarDeployment.start(AbstractWarDeployment.java:461)
        at org.jboss.web.deployers.WebModule.startModule(WebModule.java:118)
        at org.jboss.web.deployers.WebModule.start(WebModule.java:97)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:592)
        at org.jboss.mx.interceptor.ReflectedDispatcher.invoke(ReflectedDispatcher.java:157)
        at org.jboss.mx.server.Invocation.dispatch(Invocation.java:96)
        at org.jboss.mx.server.Invocation.invoke(Invocation.java:88)
        at org.jboss.mx.server.AbstractMBeanInvoker.invoke(AbstractMBeanInvoker.java:264)
        at org.jboss.mx.server.MBeanServerImpl.invoke(MBeanServerImpl.java:668)
        at org.jboss.system.microcontainer.ServiceProxy.invoke(ServiceProxy.java:206)
        at $Proxy38.start(Unknown Source)
        at org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:42)
        at org.jboss.system.microcontainer.StartStopLifecycleAction.installAction(StartStopLifecycleAction.java:37)
        at org.jboss.dependency.plugins.action.SimpleControllerContextAction.simpleInstallAction(SimpleControllerContextAction.java:62)
        at org.jboss.dependency.plugins.action.AccessControllerContextAction.install(AccessControllerContextAction.java:71)
        at org.jboss.dependency.plugins.AbstractControllerContextActions.install(AbstractControllerContextActions.java:51)
        at org.jboss.dependency.plugins.AbstractControllerContext.install(AbstractControllerContext.java:348)

Anyone knows how fix this error?

Thanks.

Tomas

[brian.stansberry]

I opened a JIRA for what I thought was a bug: https://jira.jboss.org/jira/browse/JBAS-7785

But simple testing shows that doesn't lead to an exception -- which shouldn't surprise me, since I occasionally do what you did and I think I would have noticed the error logging.

So, now I'm a bit stumped.

Looking at the JIRA, the description shows you how the ObjectName is created. The dynamic elements come from the context path for the webapp and the name of the Host in server.xml. So:

1) Please post the contents of any ROOT.war/WEB-INF/jboss-web.xml (there isn't one in a standard JBoss 5.1.0.GA)

2) Please post the contents of server/all/deploy/jbossweb.sar/server.xml

[tfrastia]

Hi,

here are my jboss-web.xml and server.xml

Thanks,
Tomas

[brian.stansberry]

I can't reproduce this. I took my build of 5.1.0.GA and dropped your jboss-web.xml in ROOT.war/WEB-INF and replace the server.xml with yours. Only difference is I commented out the mod_cluster listener from server.xml as my build doesn't have mod_cluster integrated.  Server starts cleanly and the mbean is registered in JMX.

(The use of mod_cluster should have nothing to do with this as it's uninvolved in the code path that's generating the error and it doesn't change any of the state that goes into the ObjectName.)

[jaikiran]

I think we could improve that error logging to include the ObjectName which leads to this exception. Something like:

Index: tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java
===================================================================
--- tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java (revision 101936)
+++ tomcat/src/main/java/org/jboss/web/tomcat/service/session/JBossManager.java (working copy)
@@ -1152,7 +1152,7 @@
       }
       catch (Exception ex)
       {
-         log_.error("Could not register " + getClass().getSimpleName() + " to MBeanServer", ex);
+         log_.error("Could not register " + getClass().getSimpleName() + " with ObjectName " + clusterName + " to MBeanServer", ex);
       }
    }

That might help in easy debugging for any similar issues in future.

[jaikiran]

I was able to reproduce this on AS 5.1.0 (there's a catch ):

1) On a clean AS 5.1.0, "all" profile, edit web.xml of ROOT.war to include the <distributable/> element

2) Use JDK 1.5 (this is important)

3) Start the server, you will see:

01:32:09,998 ERROR [JBossCacheManager.] Could not register JBossCacheManager to MBeanServer
javax.management.MalformedObjectNameException: Unterminated key property part
        at javax.management.ObjectName.construct(ObjectName.java:465)
        at javax.management.ObjectName.<init>(ObjectName.java:1314)
        at org.jboss.web.tomcat.service.session.JBossManager.registerManagerMBean(JBossManager.java:1074)

This exception shows up when used against (Sun) Java 1.5. If i switch to (Sun) Java 1.6, it works fine. A quick look at the implementation of ObjectName between these versions of Java shows that (Sun) Java 1.6 no longer has a specific check which throws this exception. Java 1.5 has that check and throws the exception when the ObjectName is of the form

jboss.web:type=Manager,host=localhost,path=

I haven't looked into more details yet (time for bed )

[jaikiran]

jaikiran wrote:

Java 1.5 has that check and throws the exception when the ObjectName is of the form

jboss.web:type=Manager,host=localhost,path=

From the javadoc of ObjectName:

The key properties are an unordered set of keys and associated values.

Each key is a nonempty string of characters which may not contain any of the characters comma (,), equals (=), colon, asterisk, or question mark.  The same key may not occur twice in a given ObjectName.

Each value associated with a key is a string of characters that is either unquoted or quoted.

An unquoted value is a possibly empty string of characters which may not contain any of the characters comma, equals, colon, quote, asterisk, or question mark.

So empty string as values is permitted as per the javadoc. So it might possibly have been a bug in (Sun) Java 1.5 which got fixed in 1.6

[jaikiran]

Looks like this one http://bugs.sun.com/view_bug.do?bug_id=6229396

[brian.stansberry]

Thanks, Jaikiran. I edited https://jira.jboss.org/jira/browse/JBAS-7785 to reflect your findings. I also included more information in the error message.

Unfortunately, for AS 5.1.0.GA there is no workaround except to:

1) Use JDK 6

2) Patch 5.1.0 as described in the JBAS-7785 description.