JournalStorageManager getContext & newContext

[timfox]

Why do we need both these methods?

getContext always creates a new context if one does not already exist, so why do we need a separate createContext method?

[clebert.suconic]

newContext doesn't associate the context with any thread. It's just used for CreateSession.

We will later use setContext on every invocation involving the same Server Session.

[timfox]

I still don't get it.

Why do we need newContext, if getContext also creates a new one?

[clebert.suconic]

handleCreateSession should set an OperationContext on the ServerSessionPacketHandler not on the CurrentThread.

And when creating a new Session, I want to have a brand new Context. (I don't want any previous operations on it).

Besides...  The thread context will be (should be) empty most of the time... so a getContext() will perform unecessary operations through the ThreadLocal.

ServerSessionPacketHandler will later set the context on every call involving the Session.

This was done to serialize invocations on the same session and avoid those out of orders errors.