Connection.setClientID() not throwing InvalidClientIDException on a duplicate ClientID?

[fbroek]

Hi,

I have been trying out the HornetQ 2.0.0.GA release in a standalone mode (no configuration changes, just running bin/run.bat) and I noticed that it allows duplicate clientIDs on a when using javax.jms.Connection.setClientID(). I was assuming that I would get a InvalidClientIDException when trying to set it for the second time (as per the JMS 1.1 API). When running the attached simple unit test against an old JBoss 4.0.2 I had lying around, it passes, but not against HornetQ. Am I missing something obvious here or is this similar to https://jira.jboss.org/jira/browse/JBMESSAGING-791

Thanks,

Frederik

[clebert.suconic]

Your test basically is:

    public void testDuplicate() throws Exception {

        Connection c1 = null;

        Connection c2 = null;

        try {

            c1 = cf.createConnection();

            c1.setClientID("Duplicated");

            try {

                c2 = cf.createConnection();

                c2.setClientID("Duplicated");

                fail("HornetQ is allowing duplicate clients!");

            } catch (InvalidClientIDException e) {

            }

Which I think it's ok...

You just can't have duplicate Topics. We are 100% TCK. I don't think this is illegal.

[timfox]

The test does not seem valid to me.

The JMS spec does not prevent the same client id being used set on different connections. The client id identifies the client and a particular client can own man connections.

[fbroek]

In that case I'm a bit puzzled, as the Javadoc for Connection.setClientID() says:

"If another connection with the same clientID is already  running when  this method is called, the JMS provider should detect the duplicate ID  and throw  an InvalidClientIDException." (taken from http://java.sun.com/javaee/6/docs/api/javax/jms/Connection.html#setClientID%28java.lang.String%29 )

[clebert.suconic]

This is probably an optional thing, as the TCK is passing.

The main thing here is to not accept duplicate subscriptions on a topic, and that's working fine.