Markup uniformity for h:dataTable, rich:dataTable, rich:dataGrid with attribute first

[lfryc]

Hi guys,

next screenshots illustrates that RichFaces 4.0 have some lacks in markup uniformity with respect to JSF implementation

when

attribute first = number of elements in model

• h:dataTable renders empty tr/td in tbody
• rich:dataTable renders no tr/td in tbody
• rich:dataGrid renders empty tr/td in tbody but do not set the class attribute for tr

Just wanted to recognize severity of issue - should I raise a JIRA?

h:dataTable

---

rich:dataTable

---

rich:dataGrid

(first < # of elements)

---

rich:dataGrid

(first = # of elements)

Message was edited by: Lukas Fryc - formatted to improve readability

[nbelaevski]

Lukas,

In this case hidden (i.e. display: none) row/cell(s) should be rendered. So, please fill in JIRAs for absent elements.

[lfryc]

Nick,

I raised the issue for rich:dataTable:

https://jira.jboss.org/browse/RF-9085

can you please check?

If I understand right, the empty tr/td should be rendered in the rich:dataTable case and tr should be hidden (display: none)?

What about rich:dataGrid? Applies the behaviour above also for that?

[nbelaevski]

Lukas,

Semantically valid table structure should be rendered ( for tables this presumes empty TR/TD, for lists LI, etc.). Making these phantom elements invisible minimizes impact on the user. So, to check for validity, just pass rendered HTML page to the W3C validator and it will clearly indicate problems if any.