15:43:18,247 WARN [FilterImpl] Invalid filter string: JMSExpiration<1285249398244

[veitg]

Hi.

Before creating a new issue in JIRA I would like to make sure that this is really a bug and not my fault .

We're migrating from JBoss 5.1.0 shipped JBoss Messaging 1.4.3 to HornetQ 2.1.2. After some

struggling with MDB's not receiving messages anymore (BTW: a migration guide telling about the resource adaptor thing would be great)

we get the folliowing exception:

15:43:18,247 WARN  [FilterImpl] Invalid filter string: JMSExpiration<1285249398244
java.lang.NullPointerException
    at org.hornetq.core.filter.impl.FilterImpl.match(FilterImpl.java:160)
    at org.hornetq.core.server.impl.ServerConsumerImpl.handle(ServerConsumerImpl.java:207)
    at org.hornetq.core.server.impl.QueueImpl.handle(QueueImpl.java:1384)
    at org.hornetq.core.server.impl.QueueImpl.deliver(QueueImpl.java:1175)
    at org.hornetq.core.server.impl.QueueImpl.access$700(QueueImpl.java:67)
    at org.hornetq.core.server.impl.QueueImpl$DeliverRunner.run(QueueImpl.java:1601)
    at org.hornetq.utils.OrderedExecutorFactory$OrderedExecutor$1.run(OrderedExecutorFactory.java:100)
    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
    at java.lang.Thread.run(Thread.java:619)

That worked before with JBM 1.4.3 without a problem. It's one of our components that's generating this selector string. Any ideas

why that fails?

[timfox]

You would need to explain where/how you are specifying this filter string.

But it looks like you are specifying a valid JMS selector where the system expects a core filter expression.

Core filter expression's are explained here:

http://hornetq.sourceforge.net/docs/hornetq-2.1.2.Final/user-manual/en/html/filter-expressions.html

[veitg]

Hi.

Thanks for your reply.

We're using a SLSB that get's triggered via Timer that listens periodically on a queue with the given selector. The call looks like this:

consumer = session.createConsumer(queue.getDefaultDestination(), selector);

msg = consumer.receive(10000);

session is a javax.jms.Session.

consumer is a javax.jms.MessageConsumer

selector is the String as given in the exception

The WARN with the stacktrace gets printed when consumer.receive() is invoked. the exception is not thrown - only logged.

So, is the selector correctly used or ignored? when ignored, why?

Since the header JMSExpiration isn't something HornetQ specific it should work fine I guess.

[timfox]

Please post a small runnable test program that demonstrates the issue and someone will investigate.

[veitg]

Sure. No problem. For simplicitiy I've modified the jms/queue-selector example shipped with hornetq.

Simply replaced the selector:

// Step 8. Prepare two selectors
         String redSelector = "JMSExpiration < 66666666";

Please find attached the modified .java file.

Same behavior.

[timfox]

Ok, that's because JMSExpiration is not a valid identifier for a JMS selector.

From http://download.oracle.com/javaee/6/api/javax/jms/Message.html

"Message header field references are restricted to           JMSDeliveryMode, JMSPriority,           JMSMessageID, JMSTimestamp,           JMSCorrelationID, and JMSType"

Although it's not required by the JMS spec, I can add this if you like.

In the mean-time you can workaround it, by using the core filter syntax, i.e. use 'HQExpiration < 6666666'

[veitg]

Uh. Didn't know that. Thanks for figuring that out!

Since the selector of our side is configurable, I'll switch to the HQExpiration. If the spec states that (JMSExpiration not "allowed"), I wouldn't have implemented that too . We use that selector with our own message reaper - because AFAIK JBM 1.4.3 doesn't reap/expire message without a consumer. I read somewhere that HornetQ ships with its own reaper. So probably we get rid of it anyway.

Thanks for your quick help!

[timfox]

This is now implemented in TRUNK

https://jira.jboss.org/browse/HORNETQ-528

[timfox]

Yep, HornetQ has it's own reaper