-
1. Re: Compactor params not tested
timfox Sep 10, 2009 9:38 AM (in response to timfox)Also you didn't expose your new config settings on the management control.
-
2. Re: Compactor params not tested
clebert.suconic Sep 10, 2009 3:32 PM (in response to timfox)This is being tested thorugh FileConfigurationTest already.
ConfigurationImplTest seems a bit of an overkill to me since it is only testing getters and setters, and since this is already tested through FileConfigurationTest.
Also, there are a bunch of other attributes the same way.. only tested through the Fileconfiguration. -
3. Re: Compactor params not tested
timfox Sep 10, 2009 3:34 PM (in response to timfox)"clebert.suconic@jboss.com" wrote:
This is being tested thorugh FileConfigurationTest already.
ConfigurationImplTest seems a bit of an overkill to me since it is only testing getters and setters, and since this is already tested through FileConfigurationTest.
Also, there are a bunch of other attributes the same way.. only tested through the Fileconfiguration.
It's not an overkill.
FileConfigurationTest and ConfigurationImplTest test different classes. -
4. Re: Compactor params not tested
clebert.suconic Sep 10, 2009 6:41 PM (in response to timfox)There were a bunch of other properties not tested. A few setters missing... and equals not taking every property into account.
for the equals, instead of looking up for the missed properties, I just generated an implementation automatically using eclipse. (Here code wrote itself ;-) ). It is not as pretty but that part is only used by the serialization test. -
5. Re: Compactor params not tested
timfox Sep 12, 2009 7:44 AM (in response to timfox)Did you expose and test the new properties through the messaging server control too?