Compactor params not tested

[timfox]

I noticed that when the compacting params were added to Configuration, the tests in org.hornetq.tests.unit.core.config.impl were not extended to test for these new params

[timfox]

Also you didn't expose your new config settings on the management control.

[clebert.suconic]

This is being tested thorugh FileConfigurationTest already.

ConfigurationImplTest seems a bit of an overkill to me since it is only testing getters and setters, and since this is already tested through FileConfigurationTest.

Also, there are a bunch of other attributes the same way.. only tested through the Fileconfiguration.

[timfox]

This is being tested thorugh FileConfigurationTest already.

ConfigurationImplTest seems a bit of an overkill to me since it is only testing getters and setters, and since this is already tested through FileConfigurationTest.

Also, there are a bunch of other attributes the same way.. only tested through the Fileconfiguration.

It's not an overkill.

FileConfigurationTest and ConfigurationImplTest test different classes.

[clebert.suconic]

There were a bunch of other properties not tested. A few setters missing... and equals not taking every property into account.

for the equals, instead of looking up for the missed properties, I just generated an implementation automatically using eclipse. (Here code wrote itself ;-) ). It is not as pretty but that part is only used by the serialization test.

[timfox]

Did you expose and test the new properties through the messaging server control too?