-
1. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 13, 2009 4:29 AM (in response to plugtree)Looks great :)
There is one small thing to add.
In the QueueImpl class, delivery can also occur when a message is added to a queue - we call this direct delivery (see the add method).
If the queue is paused we never want to do direct delivery either, so always add the message to the internal queue in this case.
In the test, we want to make sure both delivery cases are tested - asynchronous delivery (which you already done) and direct delivery which I just mentioned.
How about you create a patch and send it to me when you're done and we can integrate it in TRUNK? -
2. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
plugtree Sep 13, 2009 10:02 PM (in response to plugtree)Tim, from what I analyzed to support paused queues on direct deliveries I would need to add a new condition to the line 1460 of QueueImpl.java in the add method
if (direct && !backup)
to
if (direct && !backup && !paused.get())
Then it will just add the message directly to the queue without delivering.
Is that right?
Diego -
3. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 14, 2009 8:35 AM (in response to plugtree)"plugtree" wrote:
Tim, from what I analyzed to support paused queues on direct deliveries I would need to add a new condition to the line 1460 of QueueImpl.java in the add method
if (direct && !backup)
to
if (direct && !backup && !paused.get())
Then it will just add the message directly to the queue without delivering.
Is that right?
Diego
Looks good to me. -
4. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
plugtree Sep 15, 2009 12:56 AM (in response to plugtree)Tim, another thing, the queue paused/resumed state has to be replicated using the ReplicationAwareQueueControlWrapper? as this class will have those methods inherited by QueueControl.
I suppose it has to be replicated... -
5. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 15, 2009 4:50 AM (in response to plugtree)"plugtree" wrote:
Tim, another thing, the queue paused/resumed state has to be replicated using the ReplicationAwareQueueControlWrapper?
I'm making some changes in replication currently that will make that unnecessary. So you don't have to worry about replication -
6. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 15, 2009 2:38 PM (in response to plugtree)plugtree-
if you're around on IRC tomorrow, we can chat about next steps :) -
7. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 18, 2009 1:00 PM (in response to plugtree)Diego - I've merged your patch on TRUNK.
I made a few changes:
a) Reformatted code so it's in keeping with the HornetQ code style
b) Removed some unnecessary log lines
c) Changed the AtomicBoolean to a boolean
d) Got Queue control test to pass
Apart from that, looks good - thanks! :) -
8. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
plugtree Sep 18, 2009 8:47 PM (in response to plugtree)Great! Sorry about the style. Forgot to check that out. I promise to look into it in the next patch.
-
9. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 21, 2009 7:08 AM (in response to plugtree)No problem :)
If you use eclipse, then the default project file in the root of the source tree, should already apply the project code style settings.
If you use IntelliJ I believe the same applies.
If you'd like a bug to track down for your next task, how about taking a look at https://jira.jboss.org/jira/browse/HORNETQ-133 ? -
10. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 21, 2009 10:37 AM (in response to plugtree)"timfox" wrote:
If you'd like a bug to track down for your next task, how about taking a look at https://jira.jboss.org/jira/browse/HORNETQ-133 ?
Actually, it looks life Jeff is already handling that one. I'll find another task -
11. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
plugtree Sep 21, 2009 10:06 PM (in response to plugtree)What about this?
https://jira.jboss.org/jira/browse/HORNETQ-31
It's a nice to have....what do you think? -
12. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 22, 2009 10:26 AM (in response to plugtree)HornetQ-31 is actually quite tricky so I'd rather leave it until after 2.0
How about this one:
https://jira.jboss.org/jira/browse/HORNETQ-24 ? -
13. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
timfox Sep 22, 2009 10:26 AM (in response to plugtree)BTW, Diego - do you have a JIRA username?
-
14. Re: HORNETQ-82 :: Allow delivery to be paused/resumed on que
plugtree Sep 22, 2009 11:12 AM (in response to plugtree)Sounds OK.