Tests still not closing sessions

[timfox]

Guys - I'm noticing quite a few tests are *still* not closing their sessions properly!

This is probably contributing to the test suite instability.

A lot of these are new tests - there is no excuse for such sloppy practice.

I have fixed some already, please fix the rest ASAP. I don't want to do this yet again in a couple more weeks.

They include:

HornetQCrashTest
ConsumerTest
HeuristicXATest
MultiThreadCompacterTest
LargeMessageCleanupTest
QueueControlUsingCoreTest
DeleteQueueRestartTest
SecurityTest
LVQRecoveryTest
LVQTest
BasicXATest
JMSBridgeImpl

[timfox]

Also ManualReconnectionToSingleServerTest looks dodgy to me- it's throwing various exceptions but passes.

[timfox]

I am still seeing these in the logs!!

[jmesnil]

I made a pass on the last successful hudson run and fixed some tests.

The only tests which does not close their sessions are CloseConnectionOnGCTest and SessionCloseOnGCTest (which is normal) and MultiThreadCompactorTest (which is not).

I have not yet figured out why the warning is logged for MultiThreadCompactorTest while the test close its sessions in a finally block...