Getting IllegalArgumentException for empty datasource in the model

[manoj.m.agarwal]

Hi,

In my my-vdb.xml i have a model in which i don't provide the datasource name(mentioned below) and as per my project requirement i need not to provide the datasource name. I get this exception for this scenario.(It was working with Teiid 7.6)

Model Definition :-

<model name="demodata_stored_procedure">

        <translator type="demo-stored-procedure" datasource=""/>

    </model>

Error Trace :-

23:59:20,146 ERROR [org.jboss.msc.service.fail] (MSC service thread 1-4) MSC00001: Failed to start service jboss.deployment.unit."chorus.1-vdb.xml".INSTALL: org.jboss.msc.service.StartException in service jboss.deployment.unit."chorus.1-vdb.xml".INSTALL: Failed to process phase INSTALL of deployment "my-vdb.xml"

    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:119) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]

    at org.jboss.msc.service.ServiceControllerImpl$StartTask.startService(ServiceControllerImpl.java:1811) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]

    at org.jboss.msc.service.ServiceControllerImpl$StartTask.run(ServiceControllerImpl.java:1746) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]

    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) [rt.jar:1.7.0_02]

    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) [rt.jar:1.7.0_02]

    at java.lang.Thread.run(Thread.java:722) [rt.jar:1.7.0_02]

Caused by: java.lang.IllegalArgumentException: Empty name segment is not allowed for java

    at org.jboss.msc.service.ServiceName.of(ServiceName.java:85) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]

    at org.jboss.msc.service.ServiceName.append(ServiceName.java:112) [jboss-msc-1.0.2.GA.jar:1.0.2.GA]

    at org.jboss.as.naming.deployment.ContextNames.buildServiceName(ContextNames.java:178)

    at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:190)

    at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:181)

    at org.jboss.as.naming.deployment.ContextNames.bindInfoFor(ContextNames.java:290)

    at org.teiid.jboss.VDBDeployer.addDataSourceListener(VDBDeployer.java:250)

    at org.teiid.jboss.VDBDeployer.dataSourceDependencies(VDBDeployer.java:277)

    at org.teiid.jboss.VDBDeployer.deploy(VDBDeployer.java:161)

    at org.jboss.as.server.deployment.DeploymentUnitPhaseService.start(DeploymentUnitPhaseService.java:113) [jboss-as-server-7.1.1.Final.jar:7.1.1.Final]

    ... 5 more

[shawkins]

You should not supply the name at all if a source is not needed.

[manoj.m.agarwal]

Hi,

I am generating VDB dynamiclly. When i follow as you said (i dont provide datasource at all) i get this issue-

14:46:02,303 WARN  [org.teiid.RUNTIME] (teiid-async-threads - 3) TEIID50036 VDB test-vdb model "demodata_stored_procedure" metadata failed to load. Reason:TEIID31097 Connection Factory (no data source found) provided is null; Can not proceed with metadata load.

Please suggest something.

Thanks !

Manoj

[shawkins]

Manoj,

In your translator start or constructor, call ExecutionFactory.setRequiresSource(false) - otherwise we'll expect that you need a connection.  See also ExecutionFactory.setRequiresSourceMetadata.  I'll also update the logic to not default to source required unless a connection-jndi-name is specified.

Steve

[shawkins]

Manoj,

Actually I'll just highlight calling setSourceRequired in the release notes / documentation, rather than introduce even more changes.

Steve

[manoj.m.agarwal]

Sure Steve...Thanks for your valuable inputs.

Thanks !