Why com.googlecode.jtype is added into JBoss EAP 6.0.1 as a module?

[zhouyaguo]

Hi:

     Why com.googlecode.jtype is added into jboss eap 6.0.1 as a module? The module.xml has actually no useful content.

<module xmlns="urn:jboss:module:1.0" name="com.googlecode.jtype">

    <resources>

        <!-- Insert resources here -->

    </resources>

    <dependencies>

    </dependencies>

</module

ps: there is no jtype in jboss as 7.1.3 Final.

[jaikiran]

Where did you find it from? I don't see it in the git branch.

[jaikiran]

Never mind, in my local installation of EAP 6.0.1, I do see that module being installed, but it does have some content:

<?xml version="1.0" encoding="UTF-8"?>

<module xmlns="urn:jboss:module:1.0" name="com.googlecode.jtype">
    <resources>
        <resource-root path="jtype-0.1.1-redhat-2.jar"/>
        <!-- Insert resources here -->
    </resources>

    <dependencies>
    </dependencies>
</module>

Now, I don't know why this module isn't present in github upstream branch(es) nor do I know why this module is needed. I'll see if someone else knows.

[zhouyaguo]

You are right! It does have some content. After compilation from the source code, resource-root is insert into the placeholder.

I grep jtype in the source and got no luck.

[jaikiran]

You'll find it in the build.xml. Apparently hibernate validator module had a dependency on that.

[zhouyaguo]

jboss as 7:

zyg@ ~/mygit/jboss-as jboss-as$ grep -ir jtype *

build/pom.xml:                                            <packages>org.hibernate.validator:org.hibernate.validator.cfg:org.hibernate.validator.cfg.context:org.hibernate.validator.cfg.context.impl:org.hibernate.validator.cfg.defs:org.hibernate.validator.constraints:org.hibernate.validator.constraints.impl:org.hibernate.validator.engine:org.hibernate.validator.engine.groups:org.hibernate.validator.engine.resolver:org.hibernate.validator.group:org.hibernate.validator.jtype:org.hibernate.validator.messageinterpolation:org.hibernate.validator.metadata:org.hibernate.validator.metadata.location:org.hibernate.validator.method:org.hibernate.validator.method.metadata:org.hibernate.validator.resourceloading:org.hibernate.validator.util:org.hibernate.validator.util.annotationfactory:org.hibernate.validator.util.privilegedactions:org.hibernate.validator.util.scriptengine:org.hibernate.validator.xml</packages>

Binary file build/target/jboss-as-7.1.3.Final/modules/com/sun/codemodel/main/codemodel-2.6.jar matches

Binary file build/target/jboss-as-7.1.3.Final/modules/org/apache/cxf/impl/main/cxf-common-utilities-2.4.8-patch-01.jar matches

Binary file build/target/jboss-as-7.1.3.Final/modules/org/hibernate/validator/main/hibernate-validator-4.2.0.Final.jar matches

build/target/jboss-as-7.1.3.Final/modules/org/hibernate/validator/main/hibernate-validator-4.2.0.Final.jar.index:META-INF/maven/com.googlecode.jtype/jtype

build/target/jboss-as-7.1.3.Final/modules/org/hibernate/validator/main/hibernate-validator-4.2.0.Final.jar.index:META-INF/maven/com.googlecode.jtype

build/target/jboss-as-7.1.3.Final/modules/org/hibernate/validator/main/hibernate-validator-4.2.0.Final.jar.index:org/hibernate/validator/jtype

messaging/src/main/java/org/jboss/as/messaging/HornetQService.java:        JournalType jtype = configuration.getJournalType();

messaging/src/main/java/org/jboss/as/messaging/HornetQService.java:        if (jtype == JournalType.ASYNCIO) {

Binary file messaging/target/classes/org/jboss/as/messaging/HornetQService.class matches

jboss eap 6:

zyg@ ~/Downloads/jboss-eap-6.0-src jboss-eap-6.0-src$ grep -ir jtype *

build/build.xml:        <module-def name="com.googlecode.jtype">

build/build.xml:            <maven-resource group="com.googlecode.jtype" artifact="jtype"/>

build/pom.xml:                    <groupId>com.googlecode.jtype</groupId>

build/pom.xml:                    <artifactId>jtype</artifactId>

build/pom.xml:                                            <packages>org.hibernate.validator:org.hibernate.validator.cfg:org.hibernate.validator.cfg.context:org.hibernate.validator.cfg.context.impl:org.hibernate.validator.cfg.defs:org.hibernate.validator.constraints:org.hibernate.validator.constraints.impl:org.hibernate.validator.engine:org.hibernate.validator.engine.groups:org.hibernate.validator.engine.resolver:org.hibernate.validator.group:org.hibernate.validator.jtype:org.hibernate.validator.messageinterpolation:org.hibernate.validator.metadata:org.hibernate.validator.metadata.location:org.hibernate.validator.method:org.hibernate.validator.method.metadata:org.hibernate.validator.resourceloading:org.hibernate.validator.util:org.hibernate.validator.util.annotationfactory:org.hibernate.validator.util.privilegedactions:org.hibernate.validator.util.scriptengine:org.hibernate.validator.xml</packages>

build/src/main/resources/modules/com/googlecode/jtype/main/module.xml:<module xmlns="urn:jboss:module:1.0" name="com.googlecode.jtype">

build/src/main/resources/modules/org/hibernate/validator/main/module.xml:    <module name="com.googlecode.jtype"/>

messaging/src/main/java/org/jboss/as/messaging/HornetQService.java:        JournalType jtype = configuration.getJournalType();

messaging/src/main/java/org/jboss/as/messaging/HornetQService.java:        if (jtype == JournalType.ASYNCIO) {

pom.xml:                <groupId>com.googlecode.jtype</groupId>

pom.xml:                <artifactId>jtype</artifactId>

pom.xml:                <version>${version.com.googlecode.jtype}</version>

I can compile jboss as 7.1.3 Final successfully without jtype in build.xml and pom.xml.It's strange that jtype is added to eap and meanwhile is not merge to upstream.

[jaikiran]

Yaguo Zhou wrote:

I can compile jboss as 7.1.3 Final successfully without jtype in build.xml and pom.xml.It's strange that jtype is added to eap and meanwhile is not merge to upstream.

From what I've been told - In AS7 upstream that "dependency" is implicitly included within the hibernate validator jar via the maven shade plugin (i.e. those jtype classes come packaged within the hibernate validator jar). However, due to certain reasons, this wasn't allowed to be done with EAP. So they had to explicitly add that as a separate module in there. Hibernate validator no longer needs that dependency or classes and that's a reason why you won't find it in later AS7 upstream branches.

[zhouyaguo]

Thank you so much!