aries BlueprintContainerImpl missing breaks in switch statement in doRun()

[wmcdonald]

Am I missing something, or is this a problem?

Comparing two versions of the aries blueprint container impl class, it seems that the new one doesn't have break; statements after each case like the old one did.

C:\workspace-aries-1.0.1-71-047\org.apache.aries.blueprint.core-1.0.1.fuse-71-047\src\main\java\org\apache\aries\blueprint\container\BlueprintContainerImpl.java

  private void doRun() {

vs

C:\workspace-aries-0.3.1-7-061\org\apache\aries\blueprint\container\BlueprintContainerImpl.java

private void doRun() {

[gnodet_gnodet]

The break statements have been added to allow re-exuting the start of the loop each time instead of simply falling back.

This is to fail slightly faster if the container is being destroyed while still being created.

[wmcdonald]

I'm a little confused by your response. 

Version 0.3.1-7-061 (version 7.0 fuseesb ent) had break statements in. 

They were removed for version 1.0.1-71-047 (fuseesb ent version 7.1) - this doesn't make sense to have the case statements simply keep running and fall through upon each other.  My point was that this seemed like a major bug in version 1.0.1-71-047.

Aries version 1.1.0 (which I hope is in the next release of fuseesb ent) has the break statements back in.

Edited by: william.mcdonald on Mar 7, 2013 11:12 AM

[wmcdonald]

It looks like this is where the 'breaks' were put back in...

https://github.com/apache/aries/commit/3e11f4a997090e1911f178ad9814d3106373751b