-
1. Re: undoStart
camunda Feb 19, 2007 7:23 AM (in response to tom.baeyens)Hi Tom,
good points... The Use case is the following:
If I open one task (for me in Swing, but is is the same in Webapps too) I call the task, so that no other user starts the task concurrently.
If now a user just closes the Form (which can be handled easly in Swing, maybe in JSF too) I undo the start, so that the Task is again in the pool.
So my intention was really only to have it back in the actor pool and set the start date to null.
In our apps, we never change variables between start and end of a task. But If we would do so, and the users closes the Form, maybe a real Undo like you proposed is the better choice, yes.
Is that Undo ready in jbpm 3.2? Then I can switch my Command to that logic and we remove the undoStart method again, no problem.
Or we remove the method and introduce a setter for date, then I can move the logic to the Special command and explain the intetntion there...
EWhat do you think? -
2. Re: undoStart
tom.baeyens Feb 19, 2007 7:35 AM (in response to tom.baeyens)"camunda" wrote:
Or we remove the method and introduce a setter for date, then I can move the logic to the Special command and explain the intetntion there...
if you meant the a setStart(Date) then i think that would be the best solution.
undo won't be implemented any time soon. -
3. Re: undoStart
camunda Feb 19, 2007 10:00 AM (in response to tom.baeyens)Okay, I will remove the undoStart method and introduce a setStart(date). And I will link to this forum in the "CancelWorkOnTaskCommand" (not yet committed)
-
4. Re: undoStart
dmlloyd Feb 19, 2007 10:27 AM (in response to tom.baeyens)Also please stay consistent with source formatting - do not use tab characters in source files.
-
5. Re: undoStart
camunda Feb 19, 2007 10:39 AM (in response to tom.baeyens)Also please stay consistent with source formatting
no problem. Normaly I leave it to the IDE and do not touch formatting. Do you have a complete Eclipse-Formatting style ready to use?