2 Replies Latest reply on Mar 19, 2007 1:09 PM by adrian.brock

JBAS-4204, BasicQueue.removeAllMessages cleanup

starksm64 Mar 14, 2007 6:47 PM

The BasicQueue.removeAllMessages is not handling removal of msgs that have events (timeouts for example) when they are also unacknowledged. The usage that produced this issue looks to be an invalid attempt to unsubscribe a durable subscription with active msgs, but the handling of the error is leaving the subscription in a broken state.

Its seems that both the BasicQueue.removeAllMessages attempt to drop msgs that have already been dropped as well as the AbstractStateManager.setDurableSubscription handling of the unsubscribe need to be cleaned up.

1. Re: JBAS-4204, BasicQueue.removeAllMessages cleanup

adrian.brock Mar 19, 2007 1:01 PM (in response to starksm64)

I've fixed this. It shouldn't even be doing the removeAllMessages() in this case,
it should be throwing an exception to the application.

The user will now get an javax.jms.IllegalStateException
if they unsubscribe() a Durable TopicSubscription while it is still active.
Actions
2. Re: JBAS-4204, BasicQueue.removeAllMessages cleanup

adrian.brock Mar 19, 2007 1:09 PM (in response to starksm64)

Tim, you probably want to port this test to JBoss Messaging
if you don't have something similar already.
Actions

Go to original post