This content has been marked as final.
Show 4 replies
-
1. Re: Comments in code about large message replication
clebert.suconic Jan 29, 2009 8:22 AM (in response to timfox)I have made the file-copy for now... so it does work.
1468 still there for a later improvement.
and I thought I had removed this comment " This won' t work with replication".
Where did you find it? -
2. Re: Comments in code about large message replication
clebert.suconic Jan 29, 2009 8:47 AM (in response to timfox)Ahhh.... I just remembered..
the "// FIXME - this won't work with replication!!!!!!!!!!!" is yours...
for something else beyond LargeMessage
I will remove the JIRA reference, and only keep its reference on the method copy. -
3. Re: Comments in code about large message replication
clebert.suconic Jan 29, 2009 9:24 AM (in response to timfox)I removed it, you will only see your original FIXME now:
private ServerMessage makeCopy(final MessageReference ref, final boolean expiry) throws Exception { ..... // FIXME - this won't work with replication!!!!!!!!!!! long newMessageId = storageManager.generateUniqueID(); ServerMessage copy = message.copy(newMessageId); .... }
-
4. Re: Comments in code about large message replication
timfox Jan 29, 2009 9:30 AM (in response to timfox)I don't get it.
You got expiry queue, dlq to work with large messages and replication didn't you?