"clebert.suconic@jboss.com" wrote:
- In what circunstance xaSession.end(xid, XAResource.TMFAIL) would be called?

I have made this simple test. and I would expect a commit call to a failed xaSession throwing an exception:

public void testFailXID() throws Exception
 {
 Xid xid = newXID();
 ClientSession session = sessionFactory.createSession(true, false, false);
 session.start(xid, XAResource.TMNOFLAGS);
 session.end(xid, XAResource.TMFAIL);
 session.commit(xid, true); // shouldn't this throw an exception?

 session.close();

 }

And this is more a question for TM guys:

forget is used to signal that a resource manager can throw away state relating to heuristically resolved transactions. For example, if you provide a management tool that allows transactions to be manually forced to commit or rollback, you need to remember the outcome and tell the transaction manager about it if asked. You can only throw away that knowledge when told to forget.

end(TMFAIL);
commit();

is indeed an error on the part of the transaction manager. The commit should probably respond XA_RBROLLBACK if it's being polite, although XAER_PROTO would also be reasonable if it wants to signal that it's pissed of at being mistreated :-)

> So, if we commit the transaction through management, we shouldn't throw an exception if xa.commit(XID) is called.

Wrong. XA_HEURCOM is what you need in that case.

> Is there a way to replicate this behaviour through Arjuna (making it call forget)?

yes. Take a look at the XARecoveryModule implementation.

Clebert - can you add a JIRA for this and we'll look at it after beta?

We just need to persist in the journal the list of heuristically committed and rolled back xids and load them on startup, so we can respond properly to the tx mgr/recovery manager.

We can also add a management method to list the lists of heuristically committed/rolledback xids