Support for JavaScript Objects

[tilm4nn]

Hi Arquillian Community,

today I worte my first Arquillian test integrating calls to JavaScript code using the @JavaScript extension. Works like a charm as far as I can say, thanks!

Let me propose one improvement though:

At the moment String, Enum, Lists and several primitive types are supported. We often have JavaScript functions (written ourselves or from existing libraries) that take or return JavaScript objects as parameters.

For example: return { left: bounds.left, bottom: bounds.bottom, right: bounds.right, top: bounds.top } in JavaScript

At the moment these cannot be called with an interface with @JavaScript annotation. So I have to write intermediate JavaScript functions that perform the original call and return one of the values left, bottom, right, top one parameter per function.

I'd consider it very useful if JavaScript objects could be converted to/from java.util.Map on the Java side instead.

Any similar experiences? Ideas?

With kind regards

Tilmann

[kpiwko]

Hello Tilmann,

I pretty much like the idea! I think this should be simple, you can just implement/extent current DefaultExecutionResolver - see documentation here JavaScript Interface - Graphene 2 - Project Documentation Editor and source here arquillian-graphene/impl/src/main/java/org/jboss/arquillian/graphene/javascript/DefaultExecutionResolver.java at master … to support JavaScript Map to Java Map mapping. The same would be true for argument casting. I think the best way how to get it into Graphene would be to file a feature request at https://issues.jboss.org/browse/ARQGRA jira. If you accompany it with a pull request, I'm pretty sure Lukas will happily put it into next release.

Thanks,

Karel

[lfryc]

Hey Tilmann,

Karel is right, you can implement custom ExecutionResolver and achieve what you have propose.

But generally I like your idea, and I would actually go even further and implement support for JSR-353, objects JsonArray and JsonObject.

But Maps could be supported as well. For example as an adapter for JsonObject objects.

Would you mind to file a feature request?

I would actually appreciate if you could draft an implementation (in a fork of arquillian/arquillian-graphene · GitHub ) and eventually send a pull request for discussion.

But it's not strictly required. ;-)

I'm glad you like JavaScript interfaces.