JBossDeveloper

"ALRubinger" wrote:

I just checked current HEAD of SVN; Proxy is still on Beta35:

$ mvn dependency:tree -Dincludes=org.jboss.metadata |grep metadata
[INFO] \- org.jboss.metadata:jboss-metadata:jar:1.0.0.Beta35:compile

 <dependency>
 <groupId>org.jboss.metadata</groupId>
 <artifactId>jboss-metadata</artifactId>
 <version>1.0.0.Beta36</version>
 </dependency>

"ALRubinger" wrote:

The error you're seeing is because the interceptors themselves are declared in a configured interceptor stack, which is required. @see ejb3-interceptors-aop.xml (either in EJB3 Core src/main/resources or EJB3 Proxy src/test/resources). Problem is that you need for your test to load up these definitions;

"ALRubinger" wrote:

this is what I'd meant by "Add to setupBeforeClass the boilerplate for deploying *-aop.xml, example in JndiSessionRegistrarTestCaseBase (else tests will fail)". :)

Just an update - After adding the code for deploying the -aop.xml, the tests are passing locally for me. I need to clean up a few things and add one more test that i have in mind, before committing these by tomorrow. Will keep you updated.

I am done with the testcase. They are passing :)

"ALRubinger" wrote:

Some change requests to your patch (mostly housekeeping):

* Add to setupBeforeClass the boilerplate for deploying *-aop.xml,
example in JndiSessionRegistrarTestCaseBase (else tests will fail)

"ALRubinger" wrote:

* Add tests that the explicit addresses are also unbound upon undeploy

"ALRubinger" wrote:

Also, the package name / class name of the test could be more in-line with those you've done for JndiSessionRegistrarTestCaseBase; they both test pretty much the same thing, only difference is that this new one uses explicit bindings as opposed to the default. Maybe they could be merged?

"ALRubinger" wrote:

I'd just like it to be ultra-clear what these tests do from their names alone (JndiSessionRegistrarTestCaseBase sounds pretty vauge). Open to your suggestions here and then we'll move things around to be friendlier.

Done. SVN Revision: 77280