9 Replies Latest reply on Aug 28, 2008 10:00 AM by Andrew Rubinger

    Status on proxy-clustered

    Brian Stansberry Master

      I've checked in proxy-clustered. It's now in a state where with it integrated into core and with a workaround to https://jira.jboss.org/jira/browse/EJBTHREE-1471 in my local copy of proxy, I get the testsuite clusteredsession tests all passing.

      I haven't checked in the integration with core yet (which is simple; mostly looking up the clustered jndi registrars if the container is clustered). This is because with proxy-clustered, there's now a new jar and client jar that needs to be integrated into the AS build. I don't know enough about when/where you guys are integrating your builds (e.g. test systems) so I've deferred checking in the core changes until I know they won't blow something up.

        • 1. Re: Status on proxy-clustered
          Andrew Rubinger Master

          If you attach the AS integration patch to EJBTHREE-1469, I'll make the appropriate releases and integration this weekend.

          S,
          ALR

          • 2. Re: Status on proxy-clustered
            Andrew Rubinger Master

            Oh, "If you attach the AS and EJB3 Core integration patches". :)

            S,
            ALR

            • 4. Re: Status on proxy-clustered
              Brian Stansberry Master

              Patch files attached to EJBTHREE-1469.

              A few notes:

              1) The version on proxy-clustered is 0.1.3-SNAPSHOT. This is a bit of brain fart on my part; I'd forgotten you're using different numbers for each component; guess it should be 0.1.0-SNAPSHOT. But I didn't change it in case someone has already downloaded and built from svn.

              2) The ejb3-core pom has a dependency on proxy-clustered 0.1.3-SNAPSHOT, which will need to be converted to a non-snapshot once you release one.

              3) The AS patch adds adds ejb3-core 0.1.15-SNAPSHOT and proxy-clustered 0.1.3-SNAPSHOT dependencies, which will also need to be converted to non-snapshot.

              Thanks much for helping on this. It will be very nice to know this is integrated on Monday; let's me focus on other stuff. :-)

              • 5. Re: Status on proxy-clustered
                Andrew Rubinger Master

                 

                "bstansberry@jboss.com" wrote:
                1) The version on proxy-clustered is 0.1.3-SNAPSHOT. This is a bit of brain fart on my part; I'd forgotten you're using different numbers for each component; guess it should be 0.1.0-SNAPSHOT. But I didn't change it in case someone has already downloaded and built from svn.


                That's fine, the only requirement behind the point number in the version is that it increases sequentially. Plus it notes that you're starting ahead of the game. ;)

                "bstansberry@jboss.com" wrote:

                2) The ejb3-core pom has a dependency on proxy-clustered 0.1.3-SNAPSHOT, which will need to be converted to a non-snapshot once you release one.

                3) The AS patch adds adds ejb3-core 0.1.15-SNAPSHOT and proxy-clustered 0.1.3-SNAPSHOT dependencies, which will also need to be converted to non-snapshot.


                Will do.

                I might add some more into the next release of EJB3 Core, but either way we'll get some new numbers triggered in Hudson before the week starts.

                S,
                ALR

                • 6. Re: Status on proxy-clustered
                  Andrew Rubinger Master

                  No regressions on the important ejb30 test suites, so I've released ejb3-proxy-clustered, ejb3-core, and AS Integration.

                  ejb3-testsuite target "clustered-tests" locally report pass rate of 82.17%, with 18 errors in org.jboss.ejb3.test.clusteredsession.unit and 10 failures in org.jboss.ejb3.test.clusteredentity.unit. Expected?

                  S,
                  ALR

                  • 7. Re: Status on proxy-clustered
                    Brian Stansberry Master

                    That's expected yes. The clusteredentity tests are unrelated to this work; I'll look this week. IIRC, that has to do w/ including "ear=foo.jar" in ObjectNames even when no ear is involved; it's a matter of making the test expect that behavior (or better yet, getting rid of that behavior if the metadata now allows us to detect it).

                    18 clusteredsession failures sounds right. If you hack in a workaround to EJBTHREE-1471 [1], that should drop to 2. The two represents a known and acceptable change in behavior from AS 4.x where I haven't had time to tweak the test to account for it.


                    [1] The workaround; this doesn't remove CL leak; just blunt-force stops it from affecting later deployments, allowing testsuite to run properly:

                    Index: /home/bes/dev/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java
                    ===================================================================
                    --- /home/bes/dev/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java (revision 77377)
                    +++ /home/bes/dev/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java (working copy)
                    @@ -212,7 +212,11 @@
                     constructor = this.createProxyConstructor(businessInterfaces, tcl);
                    
                     }
                    - catch (ClassNotFoundException cce)
                    +// catch (ClassNotFoundException cce)
                    +// {
                    +// // Ignore
                    +// }
                    + catch (Throwable t) // BES: temporary workaround to CL leak issue so I can test
                     {
                     // Ignore
                     }
                    


                    • 8. Re: Status on proxy-clustered
                      Andrew Rubinger Master

                      Great, it's on my TODO this week to attempt a resolve on the CL leak without introducing regression in the web injection areas this dumb code was originally placed to placate.

                      S,
                      ALR

                      • 9. Re: Status on proxy-clustered
                        Andrew Rubinger Master

                        Brian:

                        Workaround for EJBTHREE-1471 should be in place now, and integrated w/ AS.

                        S,
                        ALR