JBossDeveloper

Great, thanks for the info!

Marius, can you please look at how we can use this?
Or how to apply David's fixes to our code.

David,

This is awesome. I added a fix in pretty much the same vein
(subclassing XmlWebApplicationContext, deferring to VFS-based resource pattern resolution), although there are some differences in the actual implementation. Our goal is to support:
- pattern-based resource resolution
- classpath-scanning for bean instantiation

The implementation is at:
https://anonsvn.jboss.org/repos/jbossas/projects/spring-int/trunk/deployers/src/main/java/org/jboss/spring/factory/VFSXmlWebApplicationContext.java

For making sure that what we have there is dealing with all the aspects of the problem, could you give it a try and see that it works for you?

I will take a look at your fixes for pattern resolution and try to incorporate them in what we already have. Would it be possible for you to describe the issues that you encountered and maybe provide a patch for VFSResourcePatternResolver?

Thanks,
Marius

David,

I added your fixes for scanning directories to VFSResourcePatternResolvingHelper.

Also, as a note: JBossEnabledResourcePatternResolver will work with Spring 2.5.5, but will have problems on 2.5.6 (because vfszip resources are now assumed to be jars).

So, for achieving the same result in 2.5.6, you can either:

a) override doFindPathMatchingJarResources too (having both doFindPathMatching*Resources overridden will make this work with either Spring 2.5.5 or 2.5.6)

b) use VFSXmlWebApplicationContext ;)

Marius

Hello,
I am trying to make LAMS project work on JBoss 5.
Recently we started using ContextSingletonBeanFactoryLocator in Spring. So we declared in our WARs:

<param-name>contextConfigLocation</param-name>
 <param-value>classpath:/org/lamsfoundation/lams/admin/adminApplicationContext.xml</param-value>
</context-param>
<context-param>
 <param-name>locatorFactorySelector</param-name>
 <param-value>classpath*:/org/lamsfoundation/lams/**/beanRefContext.xml</param-value>
</context-param>
<context-param>
 <param-name>parentContextKey</param-name>
 <param-value>context.central</param-value>
</context-param>

<context-param>
 <param-name>contextClass</param-name>
 <param-value>org.jboss.spring.factory.VFSXmlWebApplicationContext</param-value>
</context-param>

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE beans PUBLIC "-//SPRING//DTD BEAN//EN" "http://www.springframework.org/dtd/spring-beans.dtd">
<beans>
 <bean id="context.central"
 class="org.springframework.context.support.ClassPathXmlApplicationContext">
 <constructor-arg>
 <list>
 <value>/org/lamsfoundation/lams/applicationContext.xml</value>
 <value>/org/lamsfoundation/lams/toolApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/contentrepository/applicationContext.xml</value>
 <value>/org/lamsfoundation/lams/lesson/lessonApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/learning/learningApplicationContext.xml</value>
 <value>classpath*:org/lamsfoundation/lams/tool/**/*pplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/tool/mc/mcApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/tool/forum/forumApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/tool/noticeboard/nbApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/authoring/authoringApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/monitoring/monitoringApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/workspace/workspaceApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/web/webApplicationContext.xml</value>
 <value>/org/lamsfoundation/lams/integrationContext.xml</value>
 <value>/org/lamsfoundation/lams/usermanagement/ldapContext.xml</value>
 </list>
 </constructor-arg>
 </bean>
</beans>

Martin,

I see what you mean. We currently have the NamedXmlApplicationContext, but that will accept a single Resource as an argument, and an XmlWebApplicationContext (or subclass thereof) won't do it in your case.

We need to factor out something to that effect. I'll add a JIRA item.

Marius

Thank you, Marius.
Once you add a JIRA, please let me know the link, so I can track it (and vote for it!)

I hope a good solution can be found for GA version of JBoss 5 or preferably earlier.

Marcin

Marcin,

I added VFSClassPathXmlApplicationContext. Please give it a try.

Marius

Tried it, works fine! Thank you, Marius!

There is still one thing pending, though. It is not something I need, but it might be an issue for someone else.
I am talking about scanning for beanRefContext.xml files - see my post on Mon May 11, 2009 10:13 AM.
As I mentioned, I do not need it, since LAMS has currently only one such file and I can give the path explicitly. But one of the features of ContextSingletonBeanFactoryLocator is that it can merge several such files and create contexts based on the result. This can be very useful in some cases.

Right now PathMatchingResourcePatternResolver is used and it causes errors. I am guessing that VFSResourcePatternResolver should be used, but is there a way to make Spring do it? Something similar to "contextClass" parameter?

I tried to set contextClass to VFSClassPathXmlApplicationContex and, as expected, it did not work.

Marcin

Marcin,

Yes, that is correct. Unfortunately, ContextSingletonBeanFactoryLocator uses a ClassPathXmlApplicationContext internally.

For having the whole functionality working properly we'll need another locator class.

Marius

Hi ...
I'm a bit of a noob w.r.t. alot of this so apologies if this question is obvious or silly.

I've been trying to get a simple sample application running with JBoss 5.0 and Spring 2.5.6. I have used the fix provided in https://jira.jboss.org/jira/browse/JBSPRING-4 and my Root WebApplicationContext is started and created correctly using VFSXmlWebApplicationContext.

However when it tries to create the servlet it reverts back to XmlWebApplicationContext and I get afore mentioned FileNotFoundException.

Any help would be greatly appreciated !

web.xml

<?xml version="1.0" encoding="ISO-8859-1"?>

<web-app xmlns="http://java.sun.com/xml/ns/j2ee"
 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:schemaLocation="http://java.sun.com/xml/ns/j2ee
 http://java.sun.com/xml/ns/j2ee/web-app_2_4.xsd"
 version="2.4">

 <listener>
 <listener-class>org.springframework.web.context.ContextLoaderListener</listener-class>
 </listener>

 <context-param>
 <param-name>contextClass</param-name>
 <param-value>org.jboss.spring.factory.VFSXmlWebApplicationContext</param-value>
 </context-param>

 <context-param>
 <param-name>contextConfigLocation</param-name>
 <param-value>
 /WEB-INF/applicationContext*.xml
 </param-value>
 </context-param>

 <servlet>
 <servlet-name>amartus</servlet-name>
 <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
 <load-on-startup>1</load-on-startup>
 </servlet>

 <servlet-mapping>
 <servlet-name>amartus</servlet-name>
 <url-pattern>*.html</url-pattern>
 </servlet-mapping>

 <servlet>
 <servlet-name>service</servlet-name>
 <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
 <load-on-startup>2</load-on-startup>
 </servlet>

 <servlet-mapping>
 <servlet-name>service</servlet-name>
 <url-pattern>/service/*</url-pattern>
 </servlet-mapping>

 <welcome-file-list>
 <welcome-file>index.jsp</welcome-file>
 </welcome-file-list>

</web-app>

Mike,

What you need to do is to add a similar contextClass configuration to your DispatcherServlet. There are two application contexts that get created with your Spring application, and in your case you need to deal with both.

Marius

"marius.bogoevici" wrote:
Mike,

What you need to do is to add a similar contextClass configuration to your DispatcherServlet. There are two application contexts that get created with your Spring application, and in your case you need to deal with both.

Marius

A web application can define any number of DispatcherServlets. Each servlet will operate in its own namespace, loading its own application context with mappings, handlers, etc. Only the root application context as loaded by ContextLoaderListener, if any, will be shared.

 <servlet>
 <servlet-name>amartus</servlet-name>
 <servlet-class>org.springframework.web.servlet.DispatcherServlet</servlet-class>
 <init-param>
 <param-name>contextClass</param-name>
 <param-value>org.jboss.spring.factory.VFSXmlWebApplicationContext</param-value>
 </init-param>
 <load-on-startup>1</load-on-startup>
 </servlet>

Hmm, but ... you did too much research on this for a n00b ;)

Thanks for posting the complete configuration - as a side note, we will provide shortly a release build with these libraries and some documentation on how to use them, hopefully that will make things easier.

Marius

Just a heads-up: if you get the latest sources, you only need the jboss-spring-int-vfs jar, and please use:

org.jboss.spring.vfs.context.VFSXmlWebApplicationContext

A complete example is to be found here:

http://anonsvn.jboss.org/repos/jbossas/projects/spring-int/trunk/documentation/samples/web-scanning/

We'll follow by providing a set of downloadable jars shortly.

Hi Marius
I have another quick question, I've tried putting the new jars in the deployers dir and the jboss lib/endorsed dir but this fix only seems to work with the jars in the lib of my war. Is this expected are is it a simple JBoss classpath config issue that I don't know about.

Thanks again,
Mike.