JBossDeveloper

Hello again.

In my quest for the "working jBPM-JMS environment" I've found a new problems, and I'm wondering if this is the right forum to inform about them. I posted one of them in the Users Forum, but then, I thought that perhaps this is a better place since CVS version and new features are involved.

So, what is the preferable way to proceed. Post them here? Open JIRA bugs directly?

While I wait for your answer, here is the link to one of the problems I've found:
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=92188

I'm thinking that perhaps a workaround could be to comment out the 'web' descriptor in the application.xml ear file, and deploy into my jboss both the console war and the jbpm.ear.

Is there any code in the repository to test the JMS service messaging from the client side? I mean, something able to create the Command objects, and send them to the proper JMS queue. Looking at the code it seems to me that what I need is to create those Command subclass object (for example, a NewProcessInstanceCommand) and just send it to the queue where the CommandListener MDB is attached. Anyway, as the Command subclasses don't have a constructor, and a lot of getter and setter methods, I'm not sure of what setter methods should be invoked to create a valid Command object, but I suppose that it depends on the subclass I'm using.

Any comment about this "memory dump" ?

Regards.

Hello.

1.-I've found the problem with JSF and jbpm.ear. It was my fault (once again). It seems that the cause was that, perhaps for not running the clean target, the ear customizedwar lib directory was holding both a Sun JSF implementation and a MyFaces apache one. I suppose that the implementation was switched in some moment, and I didn't clean up my target directory as frequently as I should. BTW, deploying the jbpm-console.war and the jbpm.ear (with the 'web' node commented out) at the same time was not a valid workaround, as I run into problems with the ehcache (it looked like an NPE trying to create a second CacheManager).

2.-Before trying to setup a working cactus environment, I just wanted to create an standalone JMS client and just send a message to the JbpmCommandQueue to see how it works.

I run into some problems with the MDB CommandListener trying to locate the CommandService Session Bean. I patched as:

### Eclipse Workspace Patch 1.0
#P jbpm
Index: enterprise/cmdlistener/src/main/java/org/jbpm/ejb/impl/CommandListenerBean.java
===================================================================
RCS file: /cvsroot/jbpm/jbpm.3/enterprise/cmdlistener/src/main/java/org/jbpm/ejb/impl/CommandListenerBean.java,v
retrieving revision 1.1
diff -u -r1.1 CommandListenerBean.java
--- enterprise/cmdlistener/src/main/java/org/jbpm/ejb/impl/CommandListenerBean.java 24 Aug 2006 16:03:45 -0000 1.1
+++ enterprise/cmdlistener/src/main/java/org/jbpm/ejb/impl/CommandListenerBean.java 10 Oct 2006 16:22:29 -0000
@@ -70,8 +70,8 @@
 try {
 log.debug("looking up local command service");
 Context initial = new InitialContext();
- Context environment = (Context) initial.lookup("java:comp/env/ejb");
- LocalCommandServiceHome localCommandServiceHome = (LocalCommandServiceHome) environment.lookup("LocalCommandServiceHome");
+ Context environment = (Context) initial.lookup("java:comp/env");
+ LocalCommandServiceHome localCommandServiceHome = (LocalCommandServiceHome) environment.lookup("ejb/LocalCommandServiceBean");
 LocalCommandService localCommandService = localCommandServiceHome.create();
 try {
 // TODO add support for sending back the result

It seems that the problem is related with the fact that JBoss is not exposing the UserTransaction under java:comp/UserTransaction (that I think it's the standard or at least recommended place to expose it), it's exposed under the global JNDI namespace as 'UserTransaction'. So, I've made changes as shown in this patch:

### Eclipse Workspace Patch 1.0
#P jbpm
Index: jpdl/jar/src/main/config/hibernate.cfg.xml
===================================================================
RCS file: /cvsroot/jbpm/jbpm.3/jpdl/jar/src/main/config/hibernate.cfg.xml,v
retrieving revision 1.11
diff -u -r1.11 hibernate.cfg.xml
--- jpdl/jar/src/main/config/hibernate.cfg.xml 22 Sep 2006 14:23:25 -0000 1.11
+++ jpdl/jar/src/main/config/hibernate.cfg.xml 11 Oct 2006 10:20:58 -0000
@@ -26,7 +26,7 @@

 <!-- JTA transaction properties (begin) ===
 <property name="hibernate.transaction.factory_class">org.hibernate.transaction.JTATransactionFactory</property>
- <property name="jta.UserTransaction">java:comp/UserTransaction</property>
+ <property name="jta.UserTransaction">UserTransaction</property>
 ==== JTA transaction properties (end) -->

 <!-- CMT transaction properties (begin) ===

After the previous changes, I was able to create new ProcessInstances for an already deployed ProcessDefinition called 'Async' using a JMS standalone client, basically doing:

NewProcessInstanceCommand npic = new NewProcessInstanceCommand();
npic.setProcessName("Async");
//Setup for JMS session and producer using JNDI (omitted)
ObjectMessage om = session.createObjectMessage();
om.setObject(npic);
producer.send(om);

Thanks for the tip Tom. That led me to understand what are the previous* fields in the Command subclasses supposed to be for.

Anyway, if I understand correctly, every command in the Composite list should accept the result of the previous command execution, providing a field with previous{Class name of the previous result command}.
So, to be able to compose a command with a NewProcessInstance and a signal to make it shake, I need SignalCommand to provide a previousProcessInstance field and be able to use it to get the root token of the newly created process instance to signal it.

Is that the way to proceed?

Regards.

I think I've found a bug in the CompositeCommand injection method. The problem is that findField method is only feeded with the class of the previous command result, and since it should search into the new Command class for a field suitable to be injected with the result of the previous command, I think it's wrong (at least it's not injecting). I've changed it and now seems to work:

### Eclipse Workspace Patch 1.0
#P jbpm
Index: jpdl/jar/src/main/java/org/jbpm/command/CompositeCommand.java
===================================================================
RCS file: /cvsroot/jbpm/jbpm.3/jpdl/jar/src/main/java/org/jbpm/command/CompositeCommand.java,v
retrieving revision 1.1
diff -u -r1.1 CompositeCommand.java
--- jpdl/jar/src/main/java/org/jbpm/command/CompositeCommand.java 23 Aug 2006 15:37:37 -0000 1.1
+++ jpdl/jar/src/main/java/org/jbpm/command/CompositeCommand.java 11 Oct 2006 15:15:59 -0000
@@ -5,6 +5,8 @@
 import java.util.Iterator;
 import java.util.List;

+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 import org.jbpm.JbpmContext;
 import org.jbpm.JbpmException;

@@ -37,7 +39,7 @@
 }

 protected void tryToInject(Object lastResult, Command command) {
- Field field = findField(lastResult.getClass());
+ Field field = findField(lastResult.getClass(), command);
 if (field!=null) {
 field.setAccessible(true);
 try {
@@ -48,10 +50,10 @@
 }
 }

- protected Field findField(Class clazz) {
+ protected Field findField(Class clazz, Command command) {
 Field field = null;
 int i=0;
- Field[] fields = clazz.getDeclaredFields();
+ Field[] fields = command.getClass().getDeclaredFields();
 while ( (i<fields.length)
 && (field==null)
 ) {
@@ -63,6 +65,9 @@
 }
 i++;
 }
+ log.debug("Field to inyect for class '"+clazz.getName()+"' is '"+field+"'");
 return field;
 }
+
+ private static Log log = LogFactory.getLog(CompositeCommand.class);
 }

### Eclipse Workspace Patch 1.0
#P jbpm
Index: jpdl/jar/src/main/java/org/jbpm/command/SignalCommand.java
===================================================================
RCS file: /cvsroot/jbpm/jbpm.3/jpdl/jar/src/main/java/org/jbpm/command/SignalCommand.java,v
retrieving revision 1.3
diff -u -r1.3 SignalCommand.java
--- jpdl/jar/src/main/java/org/jbpm/command/SignalCommand.java 23 Aug 2006 15:37:37 -0000 1.3
+++ jpdl/jar/src/main/java/org/jbpm/command/SignalCommand.java 11 Oct 2006 15:19:29 -0000
@@ -24,6 +24,7 @@
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.jbpm.JbpmContext;
+import org.jbpm.graph.exe.ProcessInstance;
 import org.jbpm.graph.exe.Token;

 public class SignalCommand implements Command {
@@ -34,14 +35,23 @@
 String transitionName = null;

 Token previousToken = null;
+ ProcessInstance previousProcessInstance = null;

 public Object execute(JbpmContext jbpmContext) {
 log.debug("executing "+this);
- Token token = getToken(jbpmContext);
- if (transitionName==null) {
- token.signal();
+ if (previousProcessInstance!=null) {
+ if (transitionName==null) {
+ previousProcessInstance.signal();
+ } else {
+ previousProcessInstance.signal(transitionName);
+ }
 } else {
- token.signal(transitionName);
+ Token token = getToken(jbpmContext);
+ if (transitionName==null) {
+ token.signal();
+ } else {
+ token.signal(transitionName);
+ }
 }
 return null;
 }

2006-10-11 17:01:55,472 DEBUG [org.jbpm.svc.Services] closing service 'message': org.jbpm.msg.db.DbMessageService@6be4cc
2006-10-11 17:01:55,483 DEBUG [org.jbpm.msg.db.DbMessageService] messages were produced the jobExecutor will be signalled

Sorry for triggering questions that fast. I will try to control myself and investigate a little more before asking.

I've copied jbpm.cfg.xml to the jbpm/jpdl/jar/src/main/config/jbpm.cfg.xml and changed the message service to use the JMS based one:

<service name="message"
 factory="org.jbpm.msg.jms.JmsMessageServiceFactoryImpl" />

ConnectionFactory connectionFactory = (ConnectionFactory) initialContext.lookup(connectionFactoryJndiName);

Hello again.

I was not able to make it work with the configuration you pasted here. But I found the code where the configuration is parsed and I think that the only way to inject fields into a factory is to declare explicitly to be a BeanInfo. Looking at the code in JbpmContextInfo constructor, while iterating over the serviceElements:

if (serviceElement.hasAttribute("factory")) {
 String factoryClassName = serviceElement.getAttribute("factory");
 BeanInfo beanInfo = new BeanInfo();
 beanInfo.setClassName(factoryClassName);
 serviceFactoryObjectInfo = beanInfo;
 } else {
 Element factoryElement = XmlUtil.element(serviceElement, "factory");
 if (factoryElement==null) {
 throw new ConfigurationException("element 'service' requires either a factory attribute or a factory element");
 }
 Element factoryBeanElement = XmlUtil.element(factoryElement);
 if (factoryBeanElement==null) {
 throw new ConfigurationException("element 'factory' requires either a bean or ref element");
 }
 serviceFactoryObjectInfo = objectFactoryParser.parse(factoryBeanElement);
 }

public BeanInfo(Element beanElement, ObjectFactoryParser objectFactoryParser)

<service name="message">
 <factory><bean class="org.jbpm.msg.jms.JmsMessageServiceFactoryImpl">
 <field name="connectionFactoryJndiName"><string value="java:/XAConnectionFactory"/></field>
 <field name="destinationJndiName"><string value="queue/JbpmCommandQueue"/></field>
 </bean></factory>
 </service>

org.jbpm.JbpmException: command listener bean only can handle object messages with Command's as the object.

After spending some time looking at the code, I'm starting to suspect that what is missing here is a new MDB, pretty similar to the CommandListener one, to play as a consumer of the Jobs that got queued into the queue configured in the JmsMessageServiceImpl as destinationJndiName (that should be, of course, different from the one used for the CommandListener).

Is this true?

Regards.

Hello.

During my tests, I needed to change some config files, like hibernate.cfg.xml or jbpm.cfg.xml. For example, when I want to use an Oracle database as backend, I need to change the hibernate.cfg.xml file (that eventually gets bundled into the ear file). When I want to use the JMS based message service, I also need to setup the jbpm.cfg.xml file. I think that perhaps a good way to achieve this could be to use properties that can be overriden in the local build.properties file.

But for example, when I want to use the DB based message service, I have to write, in the service tag:

<service name="message"
 factory="org.jbpm.msg.db.DbMessageServiceFactory"/>

<service name="message">
 <factory>
 <bean class="org.jbpm.msg.jms.JmsMessageServiceImpl">
 <field name="connectionFactoryJndiName">
 <string value="java:XAConnectionFactory"/>
 </field>
 <field name="destinationJndiName">
 <string value="queue/JbpmJobQueue"/>
 </field>
 </bean>
 </factory>
</service>