-
15. Re: GetOutcomes returns additional transition
Ouch, I almost want to file a new jira issue with the subject 'correct' instead of the rejected 'review'. I doubt what the core developers would do now. Hope that Joram reacts as well ;-)
-
16. Re: GetOutcomes returns additional transition
I agree with Ronald, Bernd and Britt ... so Ronald gi ahead and file the issue ;-)
-
17. Re: GetOutcomes returns additional transition
Wow, much too harmonic here... Maybe I should change my opinion ;-))
-
18. Re: GetOutcomes returns additional transition
So is the conclusion that we should have a getOucomes like this:
public List<String> getOutcomes() { List<String> outcomes = new ArrayList<String>(); for (TransitionImpl transition: execution.getActivity().getOutgoingTransitions()) { outcomes.add(transition.getName()); } return outcomes; }
and then
task.complete() always takes the default transition (the first in our case (maybe we could add an attribute to indicate the default transition))
task.complete(String outcome) just takes the transition with the given outcome name. (that might even be null if there is one single unnamed transition)
does that describe the consensus ? -
19. Re: GetOutcomes returns additional transition
"tom.baeyens@jboss.com" wrote:
does that describe the consensus ?
I think it does. Although I would have task.complete(null) behave the same as task.complete(). Just have it always take the default transition. If there is only one (named or unnamed) that already *is* the default transition.
I'll file the jira if this is decided on.
With regard to the 'default' attribute, I'm always in favour of explicit behaviour. One could argue that if there is more then one transition and task.complete() or task.complete(null) is used and the default attribute is not there, an exception should be thrown. -
20. Re: GetOutcomes returns additional transition
Hello Tom,Ronald,
Is this something that is not going to be changed? I thought we were on somewhat of a consensus regarding this,
Is there any reason why this is still rejected?
Thanks! -
21. Re: GetOutcomes returns additional transition
Yes, since I should have opened a new jira issue according to the posts. You may do the honours though. :-)