4 Replies Latest reply on Jul 30, 2009 9:10 AM by Ronald van Kuijk

    refactoring org.jbpm.bpmn to org.jbpm.bpmn.internal?

    Ronald van Kuijk Master

      Anyone agree/disagree?

        • 1. Re: refactoring org.jbpm.bpmn to org.jbpm.bpmn.internal?
          Bernd Ruecker Master

          Is it necessary? Isn't it internal by default at the moment? Just get longer package names :-/

          Hmm, but it aligns it with jpdl, eh?

          Anyway, I committed the last local changes (without that hack in the PVM), so if you want you ccan go ahead.

          P.S: Sorry, I moved a test case from parallelGatewayTest to UserTaskTest

          • 2. Re: refactoring org.jbpm.bpmn to org.jbpm.bpmn.internal?
            Ronald van Kuijk Master

             

            Is it necessary? Isn't it internal by default at the moment? Just get longer package names :-/

            True

            Hmm, but it aligns it with jpdl, eh?

            More true ;-)

            I'll do this tonight when it is quiet.


            Anyway, I committed the last local changes (without that hack in the PVM), so if you want you ccan go ahead.

            Cool, we are in good agreement here. Only thing I'll do additionally is to introduce a boolean 'forkAllowed' so this generic method is easily reused in tasks, *all* gateways etc...


            P.S: Sorry, I moved a test case from parallelGatewayTest to UserTaskTest


            No that's fine. I had the same idea. It's the behaviour of the task, not the gateeway that is important. Otoh, it was a cool test to see that a converging parallel gateway works great without a diverging one.

            • 3. Re: refactoring org.jbpm.bpmn to org.jbpm.bpmn.internal?
              Ronald van Kuijk Master

              I'm in doubt. I can add a field to BpmnActivity and set that when parsing so the behaviour of forking or not is controlled by that. The other option is to do it in the activity by passing e.g. a boolean parameter to 'leaveBpmnActivity'. I'll do the latter first since that is already in place. Can always be refactored.

              • 4. Re: refactoring org.jbpm.bpmn to org.jbpm.bpmn.internal?
                Ronald van Kuijk Master

                I'm in doubt. I can add a field to BpmnActivity and set that when parsing so the behaviour of forking or not is controlled by that. The other option is to do it in the activity by passing e.g. a boolean parameter to 'leaveBpmnActivity' or have two methods 'leaveForked' and 'leaveSingle' or something. I'll imlpement the one with the boolean parameterd first since that is already in place. Can always be refactored.