3 Replies Latest reply on Oct 19, 2006 3:22 PM by starksm64

refactoring visitor in VFS

bill.burke Oct 5, 2006 11:28 AM

The VisitorAttributes usage seems very unclean, why not just change the Visitor interface to be:

public interface VFSVisitor {

public boolean visitTreeBranch(VirtualFile vf);
public void visitLeaf(VirtualFile vf);

}

visitTreeBranch() returns true if you want to recurse into it. Gives the developer more control over how to recurse. So, if you want to remove isArchive() the Visitor can still find out if the VF is an "archive" or not by querying the deployment context.

1. Re: refactoring visitor in VFS

adrian.brock Oct 6, 2006 11:15 AM (in response to bill.burke)

But in the context of the hypothetical classpath visitor, you wouldn't even
see the subdelpoyment to return false on.
Actions
2. Re: refactoring visitor in VFS

bill.burke Oct 6, 2006 11:53 AM (in response to bill.burke)

Still, you get a lot more flexibility on whether or not to recurse by letting the visitor decide what the parameters to recurse or not to recurse are.

That's traditionally how the visitor pattern works. The visitor decides how to recurse.
Actions
3. Re: refactoring visitor in VFS

starksm64 Oct 19, 2006 3:22 PM (in response to bill.burke)

This has been done. See Changed recurse notions in VisitorAttributes, VFS.visit:
http://www.jboss.com/index.html?module=bb&op=viewtopic&t=92962
Actions

Go to original post