JBossDeveloper

"alesj" wrote:

"adrian@jboss.org" wrote:

This requires something in the VFS, my suggestion was to add
VFSUtils.getRealURL(vfsFile);

Should I hold off VFS 2.0.0.GA until these features get into VFS?

 /**
 * Get the Real URL
 * @param vfsURL
 * @return
 * @throws Exception
 */
 public static URL getRealURL(URL vfsURL) throws Exception
 {
 if(vfsURL.getPath().endsWith("jar"))
 {
 String urlStr = "jar:" + FILE_PROTOCOL + ":" + vfsURL.getPath() + JAR_URL_SEPARATOR;
 return new URL(urlStr);
 }

 if(vfsURL.getProtocol().startsWith("vfsfile"))
 return new URL(FILE_PROTOCOL, vfsURL.getHost(), vfsURL.getPort(), vfsURL.getFile());

 if(vfsURL.getProtocol().startsWith("vfszip"))
 {
 String urlStr = vfsURL.toExternalForm();
 //nested file
 int indexJar = urlStr.indexOf(".jar");
 String beforejar = urlStr.substring("vfszip:".length(), urlStr.indexOf(".jar"));
 String afterjar = urlStr.substring(indexJar + 1 + ".jar".length());
 return new URL("jar:file:" + beforejar + ".jar " + JAR_URL_SEPARATOR + afterjar);
 }
 if(log.isTraceEnabled())
 log.trace("getRealURL did not have a match for:"+vfsURL.toExternalForm());
 return vfsURL;
 }

"adrian@jboss.org" wrote:
I said it should be
VFSUtils.getRealURL(vfsFile) above but Anil has done URL.

"adrian@jboss.org" wrote:
The closest thing that doesn't need the vfs url handlers.

"adrian@jboss.org" wrote:

"alesj" wrote:

"adrian@jboss.org" wrote:
The closest thing that doesn't need the vfs url handlers.

How do you represent multiple nested jars in real url?
(too lazy to read the spec ;-))

Or the earlier posts in this thread. ;-)

"adrian@jboss.org" wrote:

You can't do it. That's why you've got to use the closest thing.
e.g.
vfszip:/my.ear/my.rar/my.jar
would have to use the jar url for my.rar

You can roll back my changes if you like as I am not doing it any more. My 4 day tryst with VFS is not sufficient to complete this task.

Since you rolled back my changes, you can do the tasks yourself.

I only need that I need the security manager to be start able via system properties (like the classic way).

 */
 public static final String FILE_PROTOCOL = "file";

+ /**
+ * Constant representing the JAR file protocol
+ */
+ public static final String JAR_FILE_PROTOCOL = "jar:file:";
+
+ /**
+ * Constant representing the VFS ZIP protocol
+ */
+ public static final String VFSZIP_PROTOCOL = "vfszip";
+
+ /**
+ * Constant representing the VFS file protocol
+ */
+ public static final String VFS_FILE_PROTOCOL = "vfsfile";
+
 /** Standard separator for JAR URL */
 public static final String JAR_URL_SEPARATOR = "!/";

@@ -157,6 +172,40 @@

 return buffer.toString();
 }
+<<<<<<< .mine
+
+ /**
+ * Get the Real URL
+ * @param vfsURL
+ * @return
+ * @throws Exception
+ */
+ public static URL getRealURL(URL vfsURL) throws Exception
+ {
+ if(vfsURL.getProtocol().startsWith(VFS_FILE_PROTOCOL)) //vfsfile:
+ return new URL(FILE_PROTOCOL, vfsURL.getHost(), vfsURL.getPort(), vfsURL.getFile());
+
+ if(vfsURL.getProtocol().startsWith(VFSZIP_PROTOCOL)) //vfszip:
+ {
+ String urlStr = vfsURL.toExternalForm();
+
+ //Look for the first matching archive (sar, war, ear, jar)
+ String tokens[] = urlStr.split(".[a-z&&[jsrew]]ar", 2);
+
+ int lengthOfToken = tokens[0].length();
+ String typeArchive = urlStr.substring(lengthOfToken,lengthOfToken + 4);
+
+ String firstPath = tokens[0].substring(VFSZIP_PROTOCOL.length() + 1);
+
+ return new URL( new URL(JAR_FILE_PROTOCOL + firstPath + typeArchive + JAR_URL_SEPARATOR ),
+ tokens[1]);
+ }
+ if(log.isTraceEnabled())
+ log.trace("getRealURL did not have a match for:"+vfsURL.toExternalForm());
+ return vfsURL;
+ }
+=======
+>>>>>>> .r80795

"adrian@jboss.org" wrote:

"anil.saldhana@jboss.com" wrote:
Adrian, we have an opportunity to use the jar url format to specify the permissions instead of the vfs url format. I know this is not ideal but I have tested the following:

grant codeBase "jar:file:${jboss.server.home.dir}/deploy/jms-ra.rar!/jms-ra.jar/-" {

And if you put the rar in an ear, you can't do that which is why the vfs url is superior.

"anil.saldhana@jboss.com" wrote:

That was the final version I was supposed to put last night but failed and now it has been rolled back.

"alesj" wrote:

"alesj" wrote:

"adrian@jboss.org" wrote:

This requires something in the VFS, my suggestion was to add
VFSUtils.getRealURL(vfsFile);

Should I hold off VFS 2.0.0.GA until these features get into VFS?

I see Anil already added this to VFS.
But it looks wrong. ;-)

 /**
 * Get the Real URL
 * @param vfsURL
 * @return
 * @throws Exception
 */
 public static URL getRealURL(URL vfsURL) throws Exception
 {
 if(vfsURL.getPath().endsWith("jar"))
 {
 String urlStr = "jar:" + FILE_PROTOCOL + ":" + vfsURL.getPath() + JAR_URL_SEPARATOR;
 return new URL(urlStr);
 }

 if(vfsURL.getProtocol().startsWith("vfsfile"))
 return new URL(FILE_PROTOCOL, vfsURL.getHost(), vfsURL.getPort(), vfsURL.getFile());

 if(vfsURL.getProtocol().startsWith("vfszip"))
 {
 String urlStr = vfsURL.toExternalForm();
 //nested file
 int indexJar = urlStr.indexOf(".jar");
 String beforejar = urlStr.substring("vfszip:".length(), urlStr.indexOf(".jar"));
 String afterjar = urlStr.substring(indexJar + 1 + ".jar".length());
 return new URL("jar:file:" + beforejar + ".jar " + JAR_URL_SEPARATOR + afterjar);
 }
 if(log.isTraceEnabled())
 log.trace("getRealURL did not have a match for:"+vfsURL.toExternalForm());
 return vfsURL;
 }

First some simple code critique.

If you add something to project you don't sustain,
be fair and add javadocs as it should be done.
Since this is probably gonna be called for every class we load,
some more constants won't kill you.
Dunno how much optimization javac puts on "vfszip."length() and repeated ".jar".

Tests should be more exhaustive.
As I see some extra space after last ".jar that's probably not supposed to be there.
Dunno how this would work.

But in general, jar/zip handling is completely broken.
First, it should be the same code that handles it,
since, although we currently use vfszip, user can still fall back to old vfsjar handling.
And they are both the same as far as feature set goes (it's just that we have winz lock problems on vfsjar).
But the biggest problem I see is how are you gonna handle multiple nested jars.
Dunno what's the proper/real url for those, but I very much doubt it's how your code does it.
I guess this would have to be an impl of VirtualFileHandlers, not just VFSUtils.

Conclusion.
Either this is done right, or it goes out.
I'll leave it for now, but will check on it before I do 2.0.0.GA.

If you need any help on writing this, open a new forum post.
And I'll see what can be done. ;-)

"anil.saldhana@jboss.com" wrote:

I already had generated the constants. I was unable to put it back as I forgot before I slept and you rolled back.

"alesj" wrote:

As you could probably also see, I've rolled back your CL changes as well.
Using System property in such way w/o discussing it before is a huge no-no.
If you really needed that you could either
- make it true by default (as it is now)
- created few new classes in jbossas: deployer + policy combination that sets that flag to true

conf/classloader.xml

 <!--
 The classloader implementation
 -->
 <bean name="ClassLoaderSystem" class="org.jboss.classloader.spi.ClassLoaderSystem">
 <classloader><null/></classloader>
 <constructor factoryClass="org.jboss.classloader.spi.ClassLoaderSystem" factoryMethod="getInstance"/>
 </bean>

ClassLoaderSystem.java
-----------------------------
 /** The class loading system builder */
 private static final ClassLoaderSystemBuilder builder = new ClassLoaderSystemBuilder();

public static final ClassLoaderSystem getInstance()
 {
 SecurityManager sm = System.getSecurityManager();
 if (sm != null)
 sm.checkCreateClassLoader();
 return builder.get();
 }


public class ClassLoaderSystemBuilder
{
 /** The singleton */
 private static final ClassLoaderSystem singleton;

 static
 {
 singleton = AccessController.doPrivileged(new PrivilegedAction<ClassLoaderSystem>()
 {
 public ClassLoaderSystem run()
 {
 String className = System.getProperty(ClassLoaderSystem.class.getName(), DefaultClassLoaderSystem.class.getName());
 try
 {
 Class<?> clazz = Thread.currentThread().getContextClassLoader().loadClass(className);
 Object result = clazz.newInstance();
 return ClassLoaderSystem.class.cast(result);
 }
 catch (RuntimeException e)
 {
 throw e;
 }
 catch (Exception e)
 {
 throw new Error("Unexpected error loading ClassLoaderSystem " + className, e);
 }
 }
 });

 public static ClassLoaderSystem get()
 {
 return singleton;
 }
 }


DefaultClassLoaderSystem.java
-------------------------------------
public class DefaultClassLoaderSystem extends ClassLoaderSystem
{
 @Override
 protected ClassLoaderDomain createDomain(String name)
 {
 return new ClassLoaderDomain(name);
 }
}

and so on.