JBossDeveloper

Looking at
http://viewvc.jboss.org/cgi-bin/viewvc.cgi/jbossas/projects/microcontainer/trunk/classloader/src/main/org/jboss/classloader/spi/base/BaseClassLoader.java/?revision=69628&r1=69628&r2=69627

 if (result != null)
220 {
221 // Has this classloader been undeployed?
222 ClassLoader otherClassLoader = getClassLoader(result);
223 if (otherClassLoader != null && otherClassLoader != this && otherClassLoader instanceof RealClassLoader)
224 {
225 RealClassLoader rcl = (RealClassLoader) otherClassLoader;
226 // Ignore when undeployed
227 if (rcl.isValid() == false)
228 {
229 if (trace)
230 log.trace(this + " ignoring already loaded class from undeployed classloader " + ClassLoaderUtils.classToString(result));
231 result = null;
232 }
233 }
234 }

 public boolean isValid()
 {
 BaseClassLoaderPolicy basePolicy = policy;
 return basePolicy.getClassLoader() != null;
 }

 synchronized BaseClassLoader getClassLoader()
 {
 if (classLoader == null)
 throw new IllegalStateException("No classloader associated with policy therefore it is no longer registered " + toLongString());
 return classLoader;
 }

Doh! Ignore my last post, I see the impl of isValid is now

 public boolean isValid()
 {
 BaseClassLoaderPolicy basePolicy = policy;
 return basePolicy.getClassLoaderUnchecked() != null;
 }

"bstansberry@jboss.com" wrote:
Is this something we want to do for Beta4?

After the change was applied, I now see iiop tests failing:
http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-TestSuite-sun15/366/

http://hudson.qa.jboss.com/hudson/view/JBoss%20AS/job/JBoss-AS-5.0.x-TestSuite-sun15/366/testReport/

Again the weird thing is they pass locally.

The server log:

11:41:17,992 INFO [bank-iiop/Customer] Home IOR for Customer bound to bank-iiop/Customer in CORBA naming service
11:41:18,870 ERROR [WebCL] failed finding class org.jboss.test.bankiiop.interfaces._AccountHome_Stub
org.jboss.util.NestedRuntimeException: - nested throwable: (java.lang.ExceptionInInitializerError)
 at org.jboss.iiop.WebCL.findClass(WebCL.java:124)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
 at org.jboss.classloading.spi.DelegatingClassLoader.loadClass(DelegatingClassLoader.java:81)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
 at org.jboss.web.WebServer.run(WebServer.java:379)
 at org.jboss.util.threadpool.RunnableTaskWrapper.run(RunnableTaskWrapper.java:148)
 at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:650)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:675)
 at java.lang.Thread.run(Thread.java:595)
Caused by: java.lang.ExceptionInInitializerError
 at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)11:41:17,981 INFO [bank-iiop/Customer] Home IOR for Customer bound to iiop/bank-iiop/Customer in JNP naming service
 at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
 at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
 at java.lang.reflect.Constructor.newInstance(Constructor.java:494)
 at java.lang.Class.newInstance0(Class.java:350)
 at java.lang.Class.newInstance(Class.java:303)
 at org.jboss.iiop.WebCL.findClass(WebCL.java:120)
 ... 8 more
Caused by: java.lang.IllegalStateException: BaseClassLoader@a8c265{vfsfile:/qa/services/hudson/hudson_workspace/workspace/JBoss-AS-5.0.x-TestSuite-sun15/trunk/testsuite/output/lib/naming-restart.sar} classLoader is not connected to a domain (probably undeployed?) for class javax.ejb.EJBMetaData
 at org.jboss.classloader.spi.base.BaseClassLoader.loadClassFromDomain(BaseClassLoader.java:579)
 at org.jboss.classloader.spi.base.BaseClassLoader.loadClass(BaseClassLoader.java:234)
 at java.lang.ClassLoader.loadClass(ClassLoader.java:251)
 at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
 at java.lang.Class.forName0(Native Method)
 at java.lang.Class.forName(Class.java:242)
 at org.jboss.iiop.rmi.marshal.CDRStream.readerFor(CDRStream.java:183)
 at org.jboss.iiop.rmi.marshal.strategy.StubStrategy.<init>(StubStrategy.java:175)
 at org.jboss.iiop.rmi.marshal.strategy.StubStrategy.forMethod(StubStrategy.java:115)
 at org.jboss.test.bankiiop.interfaces._AccountHome_Stub.$i1(Unknown Source)
 at org.jboss.test.bankiiop.interfaces._AccountHome_Stub.<clinit>(Unknown Source)
 ... 15 more
11:41:19,233 INFO [EjbModule] Undeployed Customer
11:41:19,234 INFO [EjbModule] Undeployed Teller

Yes, they pass, e.g. with 'build tests-iiop', even if I run them multiple times.

But it fails on the full testsuite run on Hudson.

If you look at the stacktrace, its asking the wrong classloader that points to 'naming-restart.sar' which is unreleated with the test.

So if I run in between:

build one-test -Dtest=org.jboss.test.naming.test.NamingRestartUnitTestCase

but it should be the Runnable of the thread that sets/clears the TCCL. What is using the pool and not resetting the TCCL? It might be good to limit the duration of the TCCL in the pool, but the task that is using the new thread can't have the right TCCL if I understand correctly.

Its not really the WebServer's fault though as it only uses the TCCL if it could not find a ClassLoader registered based on the incoming request information that should tie back to a previous addClassLoader call. The ejb containers use this call to get the codebase for remote class loading. This should only be done for downloadServerClasses=true, which really should not be the default setting. I have changed this in the conf/jboss-service.xml. Now, the attempt to load the class will just fail if the TCCL would be used.