JBossDeveloper

Copied from
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4169019#4169019

"kabir.khan@jboss.com" wrote:

"adrian@jboss.org" wrote:

"kabir.khan@jboss.com" wrote:
.
Another problem is that for scoped deployments I am changing the beans name to something unique and adding an alias annotation containing the bean name. This breaks with the new code in BeanMetaDataDeployer. I will post more on this once I have some more information about what exactly is going on...

Why?

You'll break all sorts of assumptions related to deployment components
the metadata scopes, and reporting incomplete deployments if you do that wrong.

It seems to me that you need to take a step backwards to the original problem
and explain what you are really trying to solve, rather than try to figure out
what has broken because you are hacking at things you shouldn't. :-)

I spoke to Ales about this, it is (was) solving the problem mentioned here:
http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4154037#4154037
Basically in a scoped deployment I deploy the aop beans with a new unique name, and use an annotation to create the alias, and an annotation to deploy the bean into a scoped controller.

The mentioned alias contains the original name of the bean

I'll try to explain exactly what I am doing first. I need to do a few things in my POST_CLASSLOADER deployer org.jboss.aop.asintegration.jboss5.AbstractAopMetaDataDeployer, which handles the beans from the -aop.xml (or AOP annotations):

1) I set the correct name of the AspectManager bean to use for the beans installing aop artifacts, this is the one from conf/aop.xml if a "global" deployment. In the case of a scoped deployment, I register a new aop Domain, register that as a bean in the MC, and use it's name.

2) I also need to make sure that the pointcut expressions are deployed before any of the classes are loaded. I am currently deploying all the beanmetadata from -aop.xml myself at this stage, and stripping them out of the deployment so that they are not deployed again by BeanMetaDataDeployer. This might be overkill, maybe I should just install the pointcuts directly and allow the later deployers to install my beans as normal? I am using similar code to BeanMetaDataDeployer to deploy the beans from my deployer.

3) If it is a scoped deployment, I modify the names of the installed beans before deploying them, and add an alias using the original name, so that the aliases/original names of the aspects can still be used when injected into the bindings. I then add an annotation so that the PreInstallaction deploys the beans into a scoped controller for that deployment.

As far as I can remember from my chat with Ales, although you can have beans with the same name in sibling scopes, we also have the scenario where a scoped deployment deploys an aspect with the same name in both the "global" scope and in the "scoped" scope. The aliases/unique names are used so that AbstractController.uninstall() knows which exact bean to uninstall on undeployment.

Maybe the stuff you mention about the integration between the MDR and the scoped controllers is the underlying problem?

This is probably what Adrian said earlier in that other thread, but basically when I am putting the AspectManager into the MDR that is in the main controllers MDR. Similarly, PreInstallAction uses that repository for the context's ScopeInfo. However, in DescibeAction we use the following to obtain the repository

KernelMetaDataRepository repository = controller.getKernel().getMetaDataRepository();

"alesj" wrote:

No, they should get the same one.
See ScopedKernelInitializer.

After a few false starts, I now see that the MDR used by DescribeAction is the same as the one that I push the correct AspectManager to use to. However, the wrong metadata is got at the DescribeAction stage. I've traced through, and will describe what is happening. Hopefully someone more familiar with the MDR can shed some light, since I am not 100% sure how this should work.

My code for pushing the AspectManager is

 private String registerScopedManagerBean(int sequence, VFSDeploymentUnit unit, AspectManager scopedManager, AopMetaDataDeployerOutput output) throws DeploymentException
 {
 unit.getMutableMetaData().addMetaData(scopedManager, AspectManager.class);
 }

[APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]

 private void deploy(DeploymentUnit unit, BeanMetaData deployment) throws DeploymentException
 {
 ...
 KernelControllerContext context = new AbstractKernelControllerContext(null, deployment, null);
 //Make sure that the metadata from the deployment gets put into the context
 ScopeInfo scopeInfo = context.getScopeInfo();
 scopeInfo.setScope(unit.getScope());
 scopeInfo.setMutableScope(unit.getMutableScope());
 ...
 }

scopedInfo.setScopeInfo(unit.getScope())

[JVM=THIS, CLASS=org.jboss.beans.metadata.plugins.factory.GenericBeanFactory, INSTANCE=ScopedAlias_13_Factory$ScopedInterceptor, WORK=5644960]

[JVM=THIS, APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar, DEPLOYMENT=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]

[JVM=THIS, APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar, DEPLOYMENT=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar, CLASS=org.jboss.beans.metadata.plugins.factory.GenericBeanFactory, INSTANCE=ScopedAlias_13_Factory$ScopedInterceptor, WORK=5644960]

[INSTANCE=ScopedAlias_13_Factory$ScopedInterceptor]

[APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]

[APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]

public void addMetaData(MutableMetaDataRepository repository, ControllerContext context)
 {
 this.repository = repository;
 ScopeKey scope = getMutableScope();
 MemoryMetaDataLoader mutable = new MemoryMetaDataLoader(scope);
 repository.addMetaDataRetrieval(mutable);
 addMetaData(repository, context, mutable);
 }

[JVM=THIS, APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar, DEPLOYMENT=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]

[DEPLOYMENT=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]
[APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]
[JVM=THIS]

[APPLICATION=vfszip:/Users/kabir/sourcecontrol/jboss-head/testsuite/output/lib/aop-scopeddependency-scoped.sar]