JBossDeveloper

+
+ /**
+ * Add builder to factory.
+ */
+ public void start()
+ {
+ if (factory == null)
+ throw new IllegalArgumentException("Missing managed object factory");
+ if (type == null)
+ throw new IllegalArgumentException("Missing type");
+ if (builder == null)
+ throw new IllegalArgumentException("Missing builder");
+
+ factory.setBuilder(type, builder);
+ }

"adrian@jboss.org" wrote:


No I was talking about something like:

<bean code="...ManagedObjectDefinition">
 <property name="type">org.jboss.jms.server.destination.QueueService</property>
 <property name="builder">
 <javabean xmlns="..." class="...QueueMOBuilder"/>
 <property>
</bean>

Meaning definition should also have populator?

"alesj" wrote:
Meaning definition should also have populator?

 protected <X> ManagedObjectPopulator<X> getPopulator(Class<X> clazz)
 {
 ManagedObjectBuilder builder = getBuilder(clazz);
 if (builder instanceof ManagedObjectPopulator)
 return (ManagedObjectPopulator) builder;
 ManagedObjectPopulator<X> mop = (ManagedObjectPopulator<X>) defaultManagedObjectPopulator;
 return mop;
 }

"adrian@jboss.org" wrote:

Now that I refresh my memory on how this works. :-)
You also need to be able to specify the ManagedObjectPopulator as well.

I've added this to deployers.xml (see commented code)

 <!-- The ManagedObjectFactory -->
 <bean name="ManagedObjectFactory">
 <constructor factoryClass="org.jboss.managed.api.factory.ManagedObjectFactory" factoryMethod="getInstance"/>
 <!-- Accept any implementor of InstanceClassFactory -->
 <incallback method="addInstanceClassFactory"/>
 <uncallback method="removeInstanceClassFactory"/>
 <!-- Accept any ManagedObjectDefinition
 <incallback method="addManagedObjectDefinition"/>
 <uncallback method="removeManagedObjectDefinition"/>
 -->
 </bean>

There is a DestinationMOBuilder that builds the QueueService and TopicService destination classes ManageObjects from the QueueServiceMO and TopicServiceMO skeleton classes so that all destinations have the correct ManagedObject created without having to be annotated.

I've changed it to be more OO + use newly added mechanisms.
e.g. QueueMODefinition

public class QueueMODefinition extends ManagedObjectDefinition
{
 private static Logger log = Logger.getLogger(QueueMODefinition.class);

 public QueueMODefinition(ManagedObjectFactory factory)
 {
 super(QueueService.class, new QueueMOBuilder(factory));
 }

 private static class QueueMOBuilder implements ManagedObjectBuilder
 {
 private ManagedObjectFactory factory;

 private QueueMOBuilder(ManagedObjectFactory factory)
 {
 this.factory = factory;
 }

 /**
 * Create a ManagedObject from QueueService to QueueServiceMO.
 *
 * @param clazz - the mbean class to create the ManagedObject for
 * @param metaData - the MDR MetaData view
 */
 public ManagedObject buildManagedObject(Class<?> clazz, MetaData metaData)
 {
 ManagedObjectFactory mof = getMOFactory();
 log.debug("Creating QueueServiceMO template for: " + clazz);
 return mof.createManagedObject(QueueServiceMO.class, metaData);
 }

 /**
 * Get MO factory.
 *
 * @return the MO factory
 */
 protected ManagedObjectFactory getMOFactory()
 {
 if (factory == null)
 factory = ManagedObjectFactory.getInstance();

 return factory;
 }
 }
}