This content has been marked as final.
Show 7 replies
-
1. Re: VFS thread safety issues
alesj Apr 16, 2009 4:11 PM (in response to jason.greene)You're free to fix any thread or opt issues. ;-)
There is no concrete logic behind it
apart from how classes are "naturally" used.
e.g. single VFSContext per vfs root
The idea was to solve all FS problems,
opt kicks in later. -
2. Re: VFS thread safety issues
jason.greene Apr 16, 2009 4:16 PM (in response to jason.greene)"alesj" wrote:
You're free to fix any thread or opt issues. ;-)
There is no concrete logic behind it
apart from how classes are used.
e.g. single VFSContext per vfs root
The idea was to solve all FS problems,
opt kicks in later.
Sure, I just wanted to make sure I got the rules right before I started changing everything. Are all classes and all plugins supposed to support access from different threads? Is anything supposed to be immutable or tied to a single thread? -
3. Re: VFS thread safety issues
dmlloyd Apr 16, 2009 4:17 PM (in response to jason.greene)Just a small clarification. Thread safety is not about optimization, it's about making the appserver not randomly implode. If there's no concrete logic behind how it's supposed to work, then it's broken, and we've got a lot of work to do...
-
4. Re: VFS thread safety issues
alesj Apr 16, 2009 6:24 PM (in response to jason.greene)"david.lloyd@jboss.com" wrote:
If there's no concrete logic behind how it's supposed to work, then it's broken, and we've got a lot of work to do...
OK, let's not exaggerate. ;-)
FS is not rocket science, it has a "natural" logic.
If you have hard time grasping what the code does
we can set up a conf call and I'll try to describe how it's meant to work.
Or if Scott left some design wikis behind when he did original architecture.
Or just simply ask me what some piece does.
But in general, all code is subject to multi-thread access.
Single root - e.g. from deploy/ - should be able to handle multiple threads.
e.g. from ProfileService, HD scanner, JBAS-6330, ... -
5. Re: VFS thread safety issues
jason.greene Apr 16, 2009 6:51 PM (in response to jason.greene)Ok great thanks for the info. I'll do some updates to it over the weekend.
-
6. Re: VFS thread safety issues
alesj Apr 17, 2009 3:03 AM (in response to jason.greene)"jason.greene@jboss.com" wrote:
Ok great thanks for the info.
Not really much of an info actually. :-)
VFS is really pretty much straight fwd,
but as you could see yourself with JBAS-6715 or that past "/" discussion,
the devil is in the details, one of them being thread access."jason.greene@jboss.com" wrote:
I'll do some updates to it over the weekend.
Just ping me here on this thread if you need any help.
Meanwhile I'll port all the trunk changes to proper branches.
If I'm able to do this before you start doing your updates,
I suggest you do them into 2.1 branch and I'll later port them to trunk. -
7. Re: VFS thread safety issues
alesj Apr 17, 2009 10:37 AM (in response to jason.greene)"alesj" wrote:
If I'm able to do this before you start doing your updates,
I suggest you do them into 2.1 branch and I'll later port them to trunk.
This is done, current branch 2.1 == trunk.