JBossDeveloper

"stan.silvert@jboss.com" wrote:

Does it hurt anything to go ahead and put a VF in JNDI for all deployments?
If we did bind a VF for all, would there be much of a perf hit?
If we did bind a VF for all, would finding the markers be more expensive than just creating and binding a VF?

 if (attachmentNames != null && attachmentNames.isEmpty() == false)
 {
 for (String name : attachmentNames)
 {
 if (unit.isAttachmentPresent(name))
 return true;
 }
 }
 return false;

 <property name="attachmentNames">
 <set>
 <value>org.jboss.metadata.web.jboss.JBossWebMetaData</value>
 <value>org.jboss.metadata.ejb.jboss.JBossMetaData</value>
 </set>
 </property>

You can't bind in java:comp, because you haven't established the right context. (You need to know the component and establish it currently via ENCFactory.pushContextId(id). It's going to change into something like ENCFactory.pushComponent(component).)

public String createName(DeploymentUnit unit, ValidatorFactory factory)
{
 return "java:comp/env/" + unit.getSimpleName(); // TODO - fix this
}

"wolfc" wrote:

You are probably better off binding it into global JNDI.

"stan.silvert@jboss.com" wrote:
If you want me to do the JNDI part then I'll be glad to take a crack at it if you can give me a little guidance.

"wolfc" wrote:

Another way which I'm looking into (for EJB3) is binding an ObjectFactory which starts the (on-demand) MC bean on lookup. The binding itself isn't a performance issue.

"epbernard" wrote:

I've created a LazyValidatorFactory that allows to not initialize the VF until it's really needed. It's required to use it to avoid messing with JPA's class transformation which happens later in the deployment process
http://anonsvn.jboss.org/repos/hibernate/validator/trunk/hibernate-validator/src/main/java/org/hibernate/validation/util/LazyValidatorFactory.java

"epbernard" wrote:

On Ales's code I would change the package name from jsr303 to beanvalidation as the spec will likely make babies one day.

OK, it's changed now: jsr303 --> beanvalidation

I need to inject the "default validator factory" into the Web Beans bootstrap, so that it can be made available for injection CDI-style. What MC bean should I use? ValidatorFactoryFactory?

"pete.muir@jboss.org" wrote:
I need to inject the "default validator factory" into the Web Beans bootstrap, so that it can be made available for injection CDI-style. What MC bean should I use? ValidatorFactoryFactory?

I wasn't precise, this is another of the "services" that WB, in an EE env, requires:

http://fisheye.jboss.org/browse/JBossAS/projects/webbeans-ri-int/trunk/ejb/src/main/java/org/jboss/webbeans/integration/validation/JBossValidationServices.java

http://fisheye.jboss.org/browse/JBossAS/projects/webbeans-ri-int/trunk/deployer/src/main/assembly/resources/META-INF/webbeans-services-jboss-beans.xml?#l37

Currently my approach was to write this as an MC Bean (like other services we have), and then tell the WebBeansBootstrap about it in the deployer

If all you need is VF, we can wire it up in bootstrap deployer.
But if this is not all, or it doesn't suite us best, I guess there is no harm in using VFF.

"wolfc" wrote:
You can't bind in java:comp, because you haven't established the right context. (You need to know the component and establish it currently via ENCFactory.pushContextId(id). It's going to change into something like ENCFactory.pushComponent(component).)

public String createName(DeploymentUnit unit, ValidatorFactory factory)
{
 return "java:comp/env/" + unit.getSimpleName(); // TODO - fix this
}

You are probably better off binding it into global JNDI.

Another way which I'm looking into (for EJB3) is binding an ObjectFactory which starts the (on-demand) MC bean on lookup. The binding itself isn't a performance issue.

For the dependency something must supply jndi:name though. Or the bean name which does the binding should come from a resolver.

Ales is right, I can wire it up in Bootstrap.

"stan.silvert@jboss.com" wrote:
Because I don't yet have a JSFDeployer, I do this in our JSF ServletContextListener. The only way I can do it is to create the VF myself or get it from JNDI.
Stan