3 Replies Latest reply on Nov 21, 2008 4:46 AM by dermas

bug or feature? methodInvocation.getArguments() empty array

dermas Nov 20, 2008 11:55 AM

So the upgrade from jboss aop 1.5.6. to 2.0.0. did finally work.

Now I have a question to a different behavior:

public class Foo implements Interceptor

public Object invoke(Invocation invocation) throws Throwable {
 MethodInvocation methodInvocation = (MethodInvocation) invocation;
 methodInvocation.getArguments();
}

Ok, now I intercepted a method without parameters and methodInvocation.getArguments() acts differently:

With 1.5.6. GA:
- I get null

With 2.0.0. GA:
- I get an empty object array

So does this new behavior happen on purpose or is it a bug?

1. Re: bug or feature? methodInvocation.getArguments() empty ar

flavia.rainone Nov 20, 2008 2:41 PM (in response to dermas)

It is a consistency bug that has been fixed, actually.

In the previous version, that method would result in null on one cenario and in an empty array on a different weaving mode.

Now, we got rid of this inconsistency by making it always return an non-null array. This has also been formalized by javadoc documentation:

http://www.jboss.org/jbossaop/docs/2.0.0.GA/docs/aspect-framework/apidocs/org/jboss/aop/joinpoint/MethodInvocation.html#getArguments()

With that documentation, you are now assured that it will always return a non-null array and this won't change again, it is part of the JBoss AOP API spec.
Actions
2. Re: bug or feature? methodInvocation.getArguments() empty ar

dermas Nov 21, 2008 4:10 AM (in response to dermas)
"flavia.rainone@jboss.com" wrote:
It is a consistency bug that has been fixed, actually.

In the previous version, that method would result in null on one cenario and in an empty array on a different weaving mode.

Now, we got rid of this inconsistency by making it always return an non-null array. This has also been formalized by javadoc documentation:

http://www.jboss.org/jbossaop/docs/2.0.0.GA/docs/aspect-framework/apidocs/org/jboss/aop/joinpoint/MethodInvocation.html#getArguments()

With that documentation, you are now assured that it will always return a non-null array and this won't change again, it is part of the JBoss AOP API spec.

Ok, thx for your answer =)

Now I just need to get rid of the sysouts like:

[aop-debug] org.jboss.remoting.transport.socket.MicroSocketClientInvoker SocketClientInvoker[10eeb26, socket://127.0.0.1:3873] disconnecting ... [aop-trace] org.jboss.remoting.MicroRemoteClientInvoker SocketClientInvoker[10eeb26, socket://127.0.0.1:3873] disconnecting ...

when running my ejb in jboss as 4.2.2 and everything would be fine again :)
Actions
3. Re: bug or feature? methodInvocation.getArguments() empty ar

dermas Nov 21, 2008 4:46 AM (in response to dermas)

btw. those sysouts are on my clientside console - for example in eclipse.
Actions

Go to original post