JBossDeveloper

I've put my version here: http://bigbob.splendid.co.uk/selectitems.tar.gz. It works well but isn't well packaged (no examples etc.). If I get time to tidy it up I'll put it on the wiki.

The attached files provide a @SelectItems databinder for Seam. It has a label attribute that is the name of a field/property on each object in the outjected list. If the label attribute is empty object.toString() is used. @SelectItems can be used for any Object.

Also provided is an EntityConverter. This requires the objects specified in the <f:selectItems value="..." /> to have the Entity annotation. It should be set in your favourite way:

• 
  
• By Class (each class which requires this converter is specified in faces-config.xml)
  
• By Id (specify in faces-config.xml, specify id in view)
  
• Using EL (load from a function as an inner class)
  
• Use facelets to set as default converter for selects (I place the h:selectXXX in a source tag file with an optional converter attribute (on the source tag), if the converter attribute is not set then load the EntityConverter, code available if needed)
  
  
  Corrections/queries are most welcome.
  

I only made it work for the Object strategy, because that is all I am using currently.

I also did consider adding the object myself and this might be better, but less automatic.

I also thought that the message will not be internationalized.

For my use case this does not matter currently, but for others it could be a requirement.

My converter is handling the no selection.

I am starting to wonder about my use of converters in general.

Before with Struts I validated each form submit method individually as different actions had different validation requirements. I believe that this approach is more flexible. If I add validators or converters to elements it seems I will lose this flexibility because they have no knowledge of which button was clicked.

Maybe this is a topic for a different thread. :)

I'm just packaging my @SelectItems implementation to put it on the wiki. What package name is best to use? Something under org.jboss.seam? org.jboss.seam.extensions.selectitems perhaps?

Also what namespace for taglib.xml. Seam's uses http://jboss.com/products/seam/taglib so perhaps http://jboss.com/products/seam/extensions/selectitems/taglib?

I think that contrib is better than extensions. I'm pretty sure that the xml namespace must be a uri which limits choice somewhat.

Seam Gods, what say ye?

Go with org.jboss.seam.selectitems we will eventually include it in the codebase under src/extra or directly in the main with your agreement of course.

For the taglib go with:
http://jboss.com/products/seam/selectitems/taglib

Thanks for your contribution !

Hey,

there's a parameter for the 'SelectItems' annotation named 'valueMethod' which accept as a parameter the method name to set the 'value' for each of the selections,


A little bug there, instead of using valueMethod, there's a user of labelMethod,



So, in class SelectItemsBinder, line 122:

instead of:
String methodName = ann.labelMethod();

should be:
String methodName = ann.valueMethod();


Hope it helps,

Cheers,

Asaf.

The @SelectItems component I've discussed above is done:

http://bigbob.splendid.co.uk/selectitems.zip

I still need to improve the example and add more documentation, but the component itself is done.

Some notes (which need tidying up): http://jroller.com/page/pmuir?entry=selectitems_revisited

It's also linked from the wiki.

Something I think would be useful would be a 'how to write components guide' - covering packaging, example writing, documentation, where to submit to ...

I'm open to consolidation - as you say the binder side is very similar!

Hi,
I just had a few hours of nice debugging time with the @SelectItems stuff.

This first one works ok:

<h:selectOneListbox value="#{selector.selectedRegion}">
<f:selectItems value="#{regions}"/>
</h:selectOneListbox>

<h:selectOneListbox value="#{region}">
<f:selectItems value="#{selector.regions}"/>
</h:selectOneListbox>

@SelectItems
 public List getRegions() {
 List<Region> regions = (List<Region>) em
 .createQuery("from Region").getResultList();
 return regions;
}

2006-09-19 15:14:57,367 ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/tc3Web].[jsp]] Servlet.service() for servlet jsp threw exception
java.lang.IllegalArgumentException: Collection referenced by UISelectItems with binding '#{selector.regions}' and Component-Path : {Component-Path : [Class: javax.faces.component.UIViewRoot,ViewId: /kohteen_valinta.jsp][Class: javax.faces.component.html.HtmlForm,Id: _tc3Portlet_kohteen_valinta_WAR_TrueConcept__id0][Class: javax.faces.component.html.HtmlSelectOneListbox,Id: _tc3Portlet_kohteen_valinta_WAR_TrueConcept__id1][Class: javax.faces.component.UISelectItems,Id: _tc3Portlet_kohteen_valinta_WAR_TrueConcept__id2]} does not contain Objects of type SelectItem
 at org.apache.myfaces.util.SelectItemsIterator.next(SelectItemsIterator.java:182)
 at org.apache.myfaces.renderkit.RendererUtils.internalGetSelectItemList(RendererUtils.java:487)
 at org.apache.myfaces.renderkit.RendererUtils.getSelectItemList(RendererUtils.java:461)
 at org.apache.myfaces.renderkit.html.HtmlRendererUtils.internalRenderSelect(HtmlRendererUtils.java:272)
 at org.apache.myfaces.renderkit.html.HtmlRendererUtils.renderListbox(HtmlRendererUtils.java:235)
 at org.apache.myfaces.renderkit.html.HtmlListboxRendererBase.encodeEnd(HtmlListboxRendererBase.java:73)
 at javax.faces.component.UIComponentBase.encodeEnd(UIComponentBase.java:331)
 at javax.faces.webapp.UIComponentTag.encodeEnd(UIComponentTag.java:349)
 at javax.faces.webapp.UIComponentTag.doEndTag(UIComponentTag.java:253)
 at org.apache.jsp.kohteen_005fvalinta_jsp._jspx_meth_h_selectOneListbox_0(kohteen_005fvalinta_jsp.java:254)
 at org.apache.jsp.kohteen_005fvalinta_jsp._jspx_meth_h_form_0(kohteen_005fvalinta_jsp.java:143)
 at org.apache.jsp.kohteen_005fvalinta_jsp._jspx_meth_f_view_0(kohteen_005fvalinta_jsp.java:102)
 at org.apache.jsp.kohteen_005fvalinta_jsp._jspService(kohteen_005fvalinta_jsp.java:64)
 at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:810)