@NotNull ignored in booking demo

tim.brewer Mar 8, 2006 6:22 AM

Hi,

I've noticed that the @NotNull validator is not applied to blank fields submitted from the browser.

This can be seen in the booking demo when registering a new user, the 'Real Name:' field can be left blank. This field (User.getName) is specified as @NotNull in the User entity.

I'm guessing that the submitted fields are 0 length strings rather than nulls. Is this a problem with Seam or JSF / Hibernate ? or should I be using the min length validation or the required property on the field ?

Any pointers gratefully received.

Cheers,
Tim.

1. Re: @NotNull ignored in booking demo

gavin.king Mar 8, 2006 11:02 AM (in response to tim.brewer)

You should be using @Length(min=1)
Actions
2. Re: @NotNull ignored in booking demo

tim.brewer Mar 8, 2006 11:25 AM (in response to tim.brewer)
Thanks, but I'm not sure that is an ideal solution. Consider the following code ...

@Column(name="EMAIL_ADDRESS") @NotNull(message="Email Address is required.") @Length(min=1, message="Email Address is required.") @Length(max=500, message="Email Address must be less than 500 characters long.")

The duplicate @Length annotation is not allowed, so I can't validate both the max length and the required conditions.
Actions
3. Re: @NotNull ignored in booking demo

gavin.king Mar 8, 2006 6:07 PM (in response to tim.brewer)

It is VERY easy to extend Hibernate Validator and add your own annotations :-)
Actions
4. Re: @NotNull ignored in booking demo

patrick_ibg Mar 8, 2006 6:19 PM (in response to tim.brewer)

Can't you do:

@Length (min = 1, max = 500, message = "Email address must be between 1 and 500 characters long.")
Actions
5. Re: @NotNull ignored in booking demo

gavin.king Mar 8, 2006 6:37 PM (in response to tim.brewer)

@Length (min = 1, max = 500, message = "Email address is required and must be at most {max} characters long.")
Actions
6. Re: @NotNull ignored in booking demo

tim.brewer Mar 9, 2006 5:20 AM (in response to tim.brewer)

k, thanks folks.

My choices are manipulate the code or the english language ;-)
Actions

Go to original post