5 Replies Latest reply on Sep 3, 2007 9:14 AM by amitev

BigDecimal and JSF <f:convertNumber>

tynor Aug 30, 2007 10:09 AM

Seam 1.2.1-GA, JSF 1.2, JBoss 4.2.1-GA

I have some properties of type BigDecimal that I need to display with commas (e.g. 300,000.00). I can't use f:convertNumber's pattern:

<h:inputText id="#{id}" size="10" value="#{value}" required="#{required}">
 <f:convertNumber pattern="#,##0.00" />
</h:inputText>

since this results in a runtime error -- f:convertNumber creates a java.lang.Number -- which, sadly, BigDecimal does not conform to.

/WEB-INF/facelets/tags/inputCurrency.xhtml @15,76
value="#{value}": /capital/CapitalCallEdit.xhtml @37,81
value="#{capitalCallHome.instance.callAmount}":
java.lang.IllegalArgumentException: argument type mismatch

It's trying to pass a Long to the setCallAmount(BigDecimal val) setter:

NativeMethodAccessorImpl.invoke0(Method, Object, Object[]) line: not available [native method]
NativeMethodAccessorImpl.invoke(Object, Object[]) line: 39
DelegatingMethodAccessorImpl.invoke(Object, Object[]) line: 25
Method.invoke(Object, Object...) line: 585
BeanELResolver.setValue(ELContext, Object, Object, Object) line: 108
FacesCompositeELResolver(CompositeELResolver).setValue(ELContext, Object, Object, Object) line: 68
FacesCompositeELResolver.setValue(ELContext, Object, Object, Object) line: 93
AstValue.setValue(EvaluationContext, Object) line: 114
ValueExpressionImpl.setValue(ELContext, Object) line: 249
TagValueExpression.setValue(ELContext, Object) line: 93
AstIdentifier.setValue(EvaluationContext, Object) line: 66
ValueExpressionImpl.setValue(ELContext, Object) line: 249
TagValueExpression.setValue(ELContext, Object) line: 93
HtmlInputText(UIInput).updateModel(FacesContext) line: 765
HtmlInputText(UIInput).processUpdates(FacesContext) line: 697
UIValidateAll(UIComponentBase).processUpdates(FacesContext) line: 1056
UIDecorate(UIComponentBase).processUpdates(FacesContext) line: 1056
HtmlPanel(UIComponentBase).processUpdates(FacesContext) line: 1056
...

Is this a bug? I'm not certain - the Core JSF book (Geary/Horstman) suggests that f:convertNumber should work with BigDecimal in JSF 1.2, but I can't find any specific example that explicitly shows it should work.

I can't find a way to use NumberFormat-style conversions with BigDecimal with any off the shelf converters.

This seems to be something that many others would have encountered before me -- can anyone point me to a way to convert BigDecimal with a pattern format?

1. Re: BigDecimal and JSF <f:convertNumber>

pmuir Aug 30, 2007 7:25 PM (in response to tynor)

http://java.sun.com/javaee/javaserverfaces/1.2_MR1/docs/api/javax/faces/convert/NumberConverter.html

Looks to me like it will convert from a BigDecimal to a String, but not back (weird, I guess someone forgot something here). Best bet is to write your own BigDecimalConverter.
Actions
2. Re: BigDecimal and JSF <f:convertNumber>

atao Aug 31, 2007 5:10 AM (in response to tynor)
<f:converter converterId="javax.faces.BigDecimal"/>

but without localization or any attribut other attribute as "pattern"
Actions

3. Re: BigDecimal and JSF <f:convertNumber>

atao Aug 31, 2007 12:14 PM (in response to tynor)

And use this to get a converter with l10n:


import java.math.BigDecimal;

import javax.faces.component.UIComponent;
import javax.faces.context.FacesContext;
import javax.faces.convert.NumberConverter;

/**
 * Converts a Double or Long value provided by standard jsf number
 * converter to a BigDecimal value
 *
 * To get a locale-sensitive converter, java.text.NumberFormat is used
 * (through javax.faces.convert.NumberConverter).
 * The parsing done by java.math.BigDecimal is not affected by locale.
 * See javax.faces.convert.BigDecimalConverter
 *
 */
public class BigDecimalConverter extends NumberConverter
{

 /*
 * don't use BigDecimal ctor
 * see java.math.BigDecimal
 */
 public Object getAsObject(FacesContext context, UIComponent component, String string) {
 Object value = super.getAsObject(context, component, string);
 if (value instanceof Long) return BigDecimal.valueOf((Long) value);
 if (value instanceof Double) return BigDecimal.valueOf((Double) value);
 return value;
 }
}

4. Re: BigDecimal and JSF <f:convertNumber>

atao Sep 3, 2007 9:08 AM (in response to tynor)

Can we have such a converter in Seam UI. Is it possible?
Actions
5. Re: BigDecimal and JSF <f:convertNumber>

amitev Sep 3, 2007 9:14 AM (in response to tynor)

I also vote for such converter in seam
Actions

Go to original post