JBossDeveloper

> And an example of dependency?

look at jboss-service.xml in AS trunk and take your pick.

 <mbean code="org.jboss.invocation.local.LocalInvoker"
 name="jboss:service=invoker,type=local">
<depends>jboss:service=TransactionManager</depends>
 </mbean>

> Why the mbean XML?

Umm, because I want operations on it exposed via. JMX? Just because we use MC internally in the app server, that does not mean JMX goes away. There are still likely to be 3rd party tools wanting to use JMX to manage the server, so I need some way to wire the service up as an mbean. This seemed like the easiest route. If you can suggest another approach I'll happily change. Assuming of course I don't have to cascade the change to everything that depends on the tx manager and expects it to be an mbean.

Thanks

The JMX annotation seems a good approach at first, but when I replace the old mbean

<mbean code="com.arjuna.ats.jbossatx.jta.TransactionManagerService"
 name="jboss:service=TransactionManager">
 <attribute name="TransactionTimeout">300</attribute>
 <attribute name="ObjectStoreDir">${jboss.server.data.dir}/tx-object-store</attribute>
</mbean>

<bean name="TransactionManager" class="com.arjuna.ats.jbossatx.jta.TransactionManagerService">
 <annotation>@org.jboss.aop.microcontainer.aspects.jmx.JMX(name="jboss:service=TransactionManager", exposedInterface=com.arjuna.ats.jbossatx.jta.TransactionManagerServiceMBean.class, registerDirectly=true)</annotation>

 <property name="TransactionTimeout">300</property>
 <property name="ObjectStoreDir">${jboss.server.data.dir}/tx-object-store</property>
</bean>

 <mbean code="org.jboss.invocation.unified.server.UnifiedInvoker"
 name="jboss:service=invoker,type=unified">
 <depends>jboss:service=TransactionManager</depends>
 <depends>jboss.remoting:service=Connector,transport=socket</depends>
 </mbean>

...
14:01:46,883 INFO [JMXKernel] Legacy JMX core initialized
14:01:59,184 INFO [WebService] Using RMI server codebase: http://127.0.0.1:8083/
14:02:01,913 ERROR [ProfileServiceBootstrap] Failed to load profile: Summary of incomplete deployments (SEE PREVIOUS ERRORS FOR DETAILS):

*** CONTEXTS MISSING DEPENDENCIES: Name -> Dependency{Required State:Actual State}

jboss:service=invoker,type=jrmp
 -> jboss:service=TransactionManager{Start:** NOT FOUND **}
 -> jboss:service=TransactionManager{Create:** NOT FOUND **}
...
*** CONTEXTS IN ERROR: Name -> Error

jboss:service=TransactionManager -> ** NOT FOUND **

> You are missing the point and some code/xml

Yes, thanks Ales, the missing link seems to be the functionality in TestServiceControllerLifecycleCallback. I had assumed that declaring the annotation was sufficient, but it seems that nothing in the current AS trunk actually does anything with that annotation, or at least not at a sufficiently early stage in the lifecycle to be useful.

The code in TestServiceControllerLifecycleCallback is generic, not specific to the TransactionManager service. IMO it should be present in the AS, but I don't see it. Do I need to include it in the TS side of the integration module? To my mind the functionality should really be provided via bootstrap-beans, so in the xml for the TransactionManager I can simply reference the ServiceLifecycle bean rather than having to declare it first. Or perhaps one of the existing beans already has this functionality?

Yes, I follow (but don't necessarily agree with) the argument that the TransactionManager should be in deploy, but given that we can't put it there in the short term we need an alternative solution.

Can the ServiceControllerLifecycleCallback stuff be moved such that it is available for use in the jboss-service.xml? To my mind it belongs not in the AOP deployer but in the bootstrap or early in the jboss-service.xml, so that services can make use of it. Otherwise as far as I can tell the TransactionManager is going to have to have its own duplicate of the same functionality, which seems less than elegant.

Hmm yes, that would work. All i'm trying to avoid is duplicating the java code. Duplicating a bit of xml bothers me a lot less. From the sounds of things it would be feasible to declare a bean with class=org.jboss.system.microcontainer.jmx.ServiceControllerLifecycleCallback in the jboss-service.xml file and inject the legacy JMX kernel into it, then reference that in the TransactionManager bean xml?