1 2 Previous Next 25 Replies Latest reply on Dec 2, 2008 8:36 AM by emuckenhuber Go to original post
      • 15. Re: Alternative JAR extensions
        dmlloyd
        dmlloyd Dec 1, 2008 12:34 PM (in response to bob.mcwhirter)

        This whole system seems weird to me. Why does the MC not suspend deploying a file until there is a matching deployer for it? That would seem to be more reasonable to me.

          • Actions
        • 16. Re: Alternative JAR extensions
          emuckenhuber
          emuckenhuber Dec 1, 2008 1:23 PM (in response to bob.mcwhirter)

           

          "scott.stark@jboss.org" wrote:

          The profile service that is loaded by default now is the conf/bootstrap/profile-repository.xml. It is doing a rebuild of the structure metadata when it loads admin edits, so that must be causing this.


          It is only rebuilding the structure if you persisted managed object before, as i don't think you are doing that - i guess this is not the case.
          But to be sure - there should be some debug information in the boot.log like this: (well they are there since today :) 
          DEBUG [AbstractAttachmentStore] No persisted attachment found for deployment ...


          If i do a simple RailsStructure implements JarExtensionProvider, it is deployed before any file in the deploy directory is added to the mainDeployer. 

          DEBUG [DeployersImpl] (main) Fully Deployed vfsfile:/home/emuckenh/svn/as/jboss-5.0.0.GA/server/default/deployers/rails-jboss-beans.xml


          So not really sure yet, why your Structure shows up too late.

            • Actions
          • 17. Re: Alternative JAR extensions
            bob.mcwhirter
            bob.mcwhirter Dec 1, 2008 1:37 PM (in response to bob.mcwhirter)

            It's not so much my structure shows up too late, but rather the JEP portion shows up too late for something calling getChildren() on the deploy/ directory, it *seems*.

            It's handing the child to my deployer at the right time, but it appears that the getChildren() against deploy/ is happening before JEP installation, so it doesn't know that myapp.rails should be handled as a JAR instead of as a normal filesystem file.

            At least that's what I'm thinking is happening. A hot deploy after AS is fully running, the getChildren() is smart enough to delegate to a JARHandler for myapp.rails.

            Anyhow, I have not been able to figure it out yet.

              • Actions
            • 18. Re: Alternative JAR extensions
              emuckenhuber
              emuckenhuber Dec 1, 2008 2:04 PM (in response to bob.mcwhirter)

               

              "bob.mcwhirter" wrote:

              It's handing the child to my deployer at the right time, but it appears that the getChildren() against deploy/ is happening before JEP installation, so it doesn't know that myapp.rails should be handled as a JAR instead of as a normal filesystem file.

              At least that's what I'm thinking is happening. A hot deploy after AS is fully running, the getChildren() is smart enough to delegate to a JARHandler for myapp.rails.


              Ah now i finally understand what you mean :)
              Yes there is a call of deployDir.getChildren before your JEP is getting deployed.


                • Actions
              • 19. Re: Alternative JAR extensions
                emuckenhuber
                emuckenhuber Dec 1, 2008 2:13 PM (in response to bob.mcwhirter)

                 

                "emuckenhuber" wrote:

                Yes there is a call of deployDir.getChildren before your JEP is getting deployed.


                Actually this happens before anything else is deployed. We should be able to do that in a different way.
                I'll see if we can put this still in GA.

                  • Actions
                • 20. Re: Alternative JAR extensions
                  bob.mcwhirter
                  bob.mcwhirter Dec 1, 2008 2:13 PM (in response to bob.mcwhirter)

                   

                  "emuckenhuber" wrote:

                  Ah now i finally understand what you mean :)
                  Yes there is a call of deployDir.getChildren before your JEP is getting deployed.


                  A-ha!

                  So, it seems that since things initialized from deployers/ can affect VFS handling, deployDir.getChildren() should wait until deployers/ is fully deployed.

                  Possible?

                  Thanks,

                  -Bob

                    • Actions
                  • 21. Re: Alternative JAR extensions
                    emuckenhuber
                    emuckenhuber Dec 2, 2008 4:46 AM (in response to bob.mcwhirter)

                     

                    "bob.mcwhirter" wrote:

                    So, it seems that since things initialized from deployers/ can affect VFS handling, deployDir.getChildren() should wait until deployers/ is fully deployed.

                    Possible?


                    Possible yes, unfortunately not in the timeframe of GA.

                    But we could add your ".rails" extension by default to the deployers.xml
                    and once this is fixed we remove it again, if this would help you ?

                      • Actions
                    • 22. Re: Alternative JAR extensions
                      beve
                      beve Dec 2, 2008 5:03 AM (in response to bob.mcwhirter)

                      Hi,

                      But we could add your ".rails" extension by default to the deployers.xml
                      and once this is fixed we remove it again, if this would help you ?

                      Would it also be possible to add the '.esb' extension in that case?

                      Thanks,

                      /Daniel

                        • Actions
                      • 23. Re: Alternative JAR extensions
                        alesj
                        alesj Dec 2, 2008 5:08 AM (in response to bob.mcwhirter)

                        Let's add all legacy one's we can think of,
                        otherwise users might be in for a surprise.
                        - .beans
                        - .spring
                        - ... ?

                        Adding a TODO - to remove them once this issue is fixed (do we have a JIRA?).

                          • Actions
                        • 24. Re: Alternative JAR extensions
                          bob.mcwhirter
                          bob.mcwhirter Dec 2, 2008 8:30 AM (in response to bob.mcwhirter)

                          Yah, if you guys could add ".rails" as a jar extension for the GA, that'd be plenty fine for my needs.

                          Thanks!

                          -Bob

                            • Actions
                          • 25. Re: Alternative JAR extensions
                            emuckenhuber
                            emuckenhuber Dec 2, 2008 8:36 AM (in response to bob.mcwhirter)

                             

                            "bob.mcwhirter" wrote:
                            Yah, if you guys could add ".rails" as a jar extension for the GA, that'd be plenty fine for my needs.


                            This will be by default in AS5 GA: 

                            + <value>.spring</value>
+ <value>.rails</value>
+ <value>.esb</value>


                            There is also a jira to track further changes we need to do for the next point release:

                            https://jira.jboss.org/jira/browse/JBAS-6274

                            But keep your JEP, as this is going to be removed once this is done :)

                              • Actions
                            1 2 Previous Next