SHRINKWRAP-118: Splitting up ResourceContainer| JBoss.org Content Archive (Read Only)

1 2 Previous Next 19 Replies Latest reply on Feb 4, 2010 5:46 PM by germanescobar Go to original post

15. Re: SHRINKWRAP-118: Splitting up ResourceContainer

aslak Feb 4, 2010 7:53 AM (in response to germanescobar)

The ResourceContainer is in most cases the same as ClassContainer in where stuff ends up, but the split is there because EnterpriseArchives don't support classes, but support Resources. Think of the two containers the way Maven does, src/main/java vs src/main/resources.

ResourceContainer is still valid in the case of where/what a Archive can store.
Actions
16. Re: SHRINKWRAP-118: Splitting up ResourceContainer

germanescobar Feb 4, 2010 9:53 AM (in response to aslak)

I agree.
Actions
17. Re: SHRINKWRAP-118: Splitting up ResourceContainer

alrubinger Feb 4, 2010 4:32 PM (in response to alrubinger)

Applied.

A big congratulations to German for working his way into our codebase, providing excellent insight and a perfect patch (which moved all testcases and kept all features).

S,
ALR
Actions
18. Re: SHRINKWRAP-118: Splitting up ResourceContainer

aslak Feb 4, 2010 5:25 PM (in response to germanescobar)

to emphasise the relationship between ResourceContainer and ClassContainer, ClassContainer should probably extend ResourceContainer ... ?

German want to create a issue and patch?
Actions
19. Re: SHRINKWRAP-118: Splitting up ResourceContainer

germanescobar Feb 4, 2010 5:46 PM (in response to aslak)

Of course!!
Actions

1 2 Previous Next