-
1. Re: Modules with null ClassLoaders
flavia.rainone Feb 5, 2010 7:55 AM (in response to flavia.rainone)flavia.rainone@jboss.com wrote:
That didn't break of the tests. Thinking again, it makes a lot of sense to skip the registration of such modules. Given that the newly created class pool will be mapped to a null class loader, it is useless. We are just generating overhead that way.
Now I wonder which scenarios registerBootstrapLoaders is really needed for.
-
2. Re: Modules with null ClassLoaders
kabirkhan Feb 5, 2010 8:25 AM (in response to flavia.rainone)flavia.rainone@jboss.com wrote:
flavia.rainone@jboss.com wrote:
That didn't break of the tests. Thinking again, it makes a lot of sense to skip the registration of such modules. Given that the newly created class pool will be mapped to a null class loader, it is useless. We are just generating overhead that way.
Now I wonder which scenarios registerBootstrapLoaders is really needed for.
That was probably just me fumbling in the dark :-) If some of them are not null, the purpose is probably to register those. Or are all of them null? I'm not familiar enough with the classloading/Module stuff to really know why the modules would have null classloaders
-
3. Re: Modules with null ClassLoaders
flavia.rainone Feb 5, 2010 8:32 AM (in response to flavia.rainone)I created a Jira for this issue: JBREFLECT-95 -
4. Re: Modules with null ClassLoaders
flavia.rainone Feb 5, 2010 8:44 AM (in response to kabirkhan)kabir.khan@jboss.com wrote:
That was probably just me fumbling in the dark :-) If some of them are not null, the purpose is probably to register those. Or are all of them null? I'm not familiar enough with the classloading/Module stuff to really know why the modules would have null classloaders
Thanks for the response!
I'll check that to see if this method is reallly needed.
-
5. Re: Modules with null ClassLoaders
flavia.rainone Feb 5, 2010 1:10 PM (in response to flavia.rainone)flavia.rainone@jboss.com wrote:
I'll wait until all tests are passing before I try to remove that method.
-
6. Re: Modules with null ClassLoaders
flavia.rainone Feb 10, 2010 5:43 PM (in response to kabirkhan)kabir.khan@jboss.com wrote:
That was probably just me fumbling in the dark :-) If some of them are not null, the purpose is probably to register those. Or are all of them null? I'm not familiar enough with the classloading/Module stuff to really know why the modules would have null classloaders
I just removed registerBootstrapLoaders body to test that. And it turns out that there are modules that are not null and that should be registered. I'm getting several failures at the AOP/AS tests with registerBootstrapLoaders disabled. So, I'll keep things the way they are.